fix: Test latest_dataset is not none when bounding_box is None #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgamez
reviewed
Jun 19, 2024
| @@ -72,6 +72,9 @@ docker rm $container_name | |||
| # delete the data | |||
| rm -rf $SCRIPT_PATH/../data | |||
|
|
|||
| # Add a slight delay because sometimes Docker does not seem ready after the rm. | |||
| sleep 5 | |||
| @@ -125,20 +125,7 @@ def test_gtfs_feeds_get(client: TestClient, mocker): | |||
| subdivision_name="test_subdivision_name", | |||
| municipality="test_municipality", | |||
| ) | |||
| mock_bounding_box = json.dumps( | |||
There was a problem hiding this comment.
[suggestion]: to have better coverage, I suggest creating a test for the missing bounding box, leaving this test as it covers the bounding box's presence and structure.
There was a problem hiding this comment.
Actually AFAIK the bounding box is not checked in this test.
I could add an assert for the bounding box in this test and create a new one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #440
Tested the conditions that lead to #431
Expected behavior:
These tests pass:
mobility-feed-api/api/tests/unittest/test_feeds.py
Line 114 in 8eee5c9
mobility-feed-api/api/tests/unittest/test_feeds.py
Line 199 in 8ebbffe
Testing tips:
To test I put back the code from PR #433 in api/src/feeds/impl/feeds_api_impl.py and verified that it failed.
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything