Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: seo improvements v2 #868

Merged
merged 6 commits into from
Jan 7, 2025
Merged

Conversation

Alessandro100
Copy link
Contributor

closes #860

Summary:

  • Added a site map so search engines can find all our feed pages ex: feeds/mdb-125
  • Adding canonical link references in the head so search engines knows these pages are distinct
  • Preventing google from crawling DEV / QA environments
  • Improving the HTML structure on Mobile (since thats how google crawls)
  • Link the MobilityDatabase from Mobilitydata.org

bonus

  • refactored mobile side menu for better structure

Expected behavior:

  • Mobilitydatabase should not be crawlable in QA and DEV
  • The navigation menu in mobile and desktop should work as always
  • Improved crawlability of the mobilitydatabase website

Testing tips:

Test the navigation elements on mobile and desktop and make sure they go to the correct pages

Note
The generation of the sitemap is done with a script that will be improved in the future if returns are noticed
Documentation of the SEO journey can be found here
https://docs.google.com/document/d/1beFarbPOLr_RgWqJIlc1AtlGaoFSOXlShCUfYPPNedE/edit?usp=sharing

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

image

@Alessandro100 Alessandro100 self-assigned this Jan 7, 2025
@Alessandro100 Alessandro100 force-pushed the feat/860-seo-improvements-v2 branch from 48c5721 to 0ef72e9 Compare January 7, 2025 18:37
Copy link

github-actions bot commented Jan 7, 2025

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-868-k24ztw18.web.app

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -269,6 +269,13 @@ jobs:
- name: Build
working-directory: web-app
run: yarn build:${FIREBASE_PROJECT}

- name: Set robots.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the Set robots.txt step before Build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find, it's fixed
image

@Alessandro100 Alessandro100 merged commit 2cc6d67 into main Jan 7, 2025
4 checks passed
@Alessandro100 Alessandro100 deleted the feat/860-seo-improvements-v2 branch January 7, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MobilityDatabase SEO Improvements V2
2 participants