-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: seo improvements v2 #868
Conversation
48c5721
to
0ef72e9
Compare
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-868-k24ztw18.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -269,6 +269,13 @@ jobs: | |||
- name: Build | |||
working-directory: web-app | |||
run: yarn build:${FIREBASE_PROJECT} | |||
|
|||
- name: Set robots.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the Set robots.txt
step before Build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closes #860
Summary:
bonus
Expected behavior:
Testing tips:
Test the navigation elements on mobile and desktop and make sure they go to the correct pages
Note
The generation of the sitemap is done with a script that will be improved in the future if returns are noticed
Documentation of the SEO journey can be found here
https://docs.google.com/document/d/1beFarbPOLr_RgWqJIlc1AtlGaoFSOXlShCUfYPPNedE/edit?usp=sharing
./scripts/api-tests.sh
to make sure you didn't break anything