Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR - custom title and desc for "error" urls #16

Closed
Jimmi08 opened this issue Jul 3, 2022 · 7 comments
Closed

FR - custom title and desc for "error" urls #16

Jimmi08 opened this issue Jul 3, 2022 · 7 comments

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Jul 3, 2022

Wrong urls are urls without wrapper ID or with wrong ID

Actual state:

  • with e_DEBUG error message (red) is displayed and title Wrapper

Needed:

  • customized title
  • customized message - without message box in not debug mode
Jimmi08 added a commit to Jimako-e107-plugins/wrapper that referenced this issue Jul 3, 2022
@Moc
Copy link
Owner

Moc commented Jul 7, 2022

Debug mode is for debugging (ie. solving bugs), not for general usage.

In what kind of scenarios do you want to display customized titles & messages?

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Jul 7, 2022

https://www.e107sk.com/documentation/

it doesn't display title because weird theme behaviour, it is not intention... I will fix it sometimes.

@Moc
Copy link
Owner

Moc commented Jul 7, 2022

Thanks for the link but can you describe the scenarios in which you would want to display custom titles (other than already defined in the wrapper itself) and custom messages when for example?

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Jul 7, 2022

This is for error URLs so no titles from wrapper itself can be used (wrapper is not existing, but url is)

@Moc
Copy link
Owner

Moc commented Jul 7, 2022

So in case the wrapper ID does not exist (or isn't entered) you want to display no caption? Do I understand that correctly?

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Jul 7, 2022

Not fully :)
This is wrapper url, everything is ok
/documentation/2/e107-developer-guide
this work too
/documentation/2/
but
this was returning ugly error and it is not error in fact, it is plugin frontpage.
/documentation/

That error shouldn't be there. It is not error, that page exists just without content.
I added content just to use existing link.

@Moc
Copy link
Owner

Moc commented Jul 9, 2022

I've made some changes:

  • In case of errors, the caption now is LAN_ERROR (instead of LAN_WRAPPER_NAME)
  • In case no id is entered (yourwebsite.com/wrapper/ or alias), the error LAN_WRAPPER_ERR1 is shown.

Now I think I understand your goal: add a custom "homepage" for the wrapper plugin (in your case a landing page for all documentation). I'll think about if I'll add it to the plugin. I'll get back to you on this.

@Moc Moc closed this as completed in 1a6f27a Jul 31, 2022
Moc added a commit that referenced this issue Jul 31, 2022
@Moc Moc added this to the v1.4.0 milestone Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants