Pass corePlugins by const-reference in savegame.

ModOrganizer2 · Jun 13, 2024 · 7c02e42 · 7c02e42
1 parent 10d5ba9
commit 7c02e42
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 15 deletions.
diff --git a/src/gamebryo/game_gamebryo_en.ts b/src/gamebryo/game_gamebryo_en.ts
@@ -119,11 +119,17 @@
     <message>
         <location filename="gamebryosavegameinfowidget.cpp" line="116"/>
         <location filename="gamebryosavegameinfowidget.cpp" line="154"/>
+        <location filename="gamebryosavegameinfowidget.cpp" line="193"/>
         <source>None</source>
         <translation type="unfinished"></translation>
     </message>
     <message>
         <location filename="gamebryosavegameinfowidget.cpp" line="122"/>
+        <source>Missing ESHs</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <location filename="gamebryosavegameinfowidget.cpp" line="161"/>
         <source>Missing ESLs</source>
         <translation type="unfinished"></translation>
     </message>
@@ -136,27 +142,27 @@
         <translation type="unfinished"></translation>
     </message>
     <message>
-        <location filename="gamebryosavegame.cpp" line="46"/>
+        <location filename="gamebryosavegame.cpp" line="48"/>
         <source>%1, #%2, Level %3, %4</source>
         <translation type="unfinished"></translation>
     </message>
     <message>
-        <location filename="gamebryosavegame.cpp" line="100"/>
+        <location filename="gamebryosavegame.cpp" line="102"/>
         <source>failed to open %1</source>
         <translation type="unfinished"></translation>
     </message>
     <message>
-        <location filename="gamebryosavegame.cpp" line="110"/>
+        <location filename="gamebryosavegame.cpp" line="112"/>
         <source>wrong file format - expected %1 got &apos;%2&apos; for %3</source>
         <translation type="unfinished"></translation>
     </message>
     <message>
-        <location filename="gamegamebryo.cpp" line="323"/>
+        <location filename="gamegamebryo.cpp" line="318"/>
         <source>failed to query registry path (preflight): %1</source>
         <translation type="unfinished"></translation>
     </message>
     <message>
-        <location filename="gamegamebryo.cpp" line="331"/>
+        <location filename="gamegamebryo.cpp" line="326"/>
         <source>failed to query registry path (read): %1</source>
         <translation type="unfinished"></translation>
     </message>

diff --git a/src/gamebryo/gamebryosavegame.cpp b/src/gamebryo/gamebryosavegame.cpp
@@ -511,7 +511,7 @@ float_t GamebryoSaveGame::FileWrapper::readFloat(int bytesToIgnore)
 
 QStringList GamebryoSaveGame::FileWrapper::readPlugins(int bytesToIgnore,
                                                        bool extraData,
-                                                       const QStringList corePlugins)
+                                                       const QStringList& corePlugins)
 {
   if (m_CompressionType == 0) {
     if (bytesToIgnore > 0)  // Just to make certain
@@ -528,9 +528,9 @@ QStringList GamebryoSaveGame::FileWrapper::readPlugins(int bytesToIgnore,
   return {};
 }
 
-QStringList GamebryoSaveGame::FileWrapper::readLightPlugins(int bytesToIgnore,
-                                                            bool extraData,
-                                                            const QStringList corePlugins)
+QStringList
+GamebryoSaveGame::FileWrapper::readLightPlugins(int bytesToIgnore, bool extraData,
+                                                const QStringList& corePlugins)
 {
   if (m_CompressionType == 0) {
     if (bytesToIgnore > 0)  // Just to make certain
@@ -547,9 +547,9 @@ QStringList GamebryoSaveGame::FileWrapper::readLightPlugins(int bytesToIgnore,
   return {};
 }
 
-QStringList GamebryoSaveGame::FileWrapper::readMediumPlugins(int bytesToIgnore,
-                                                             bool extraData,
-                                                             const QStringList corePlugins)
+QStringList
+GamebryoSaveGame::FileWrapper::readMediumPlugins(int bytesToIgnore, bool extraData,
+                                                 const QStringList& corePlugins)
 {
   if (m_CompressionType != 1) {
     return {};

diff --git a/src/gamebryo/gamebryosavegame.h b/src/gamebryo/gamebryosavegame.h
@@ -168,15 +168,15 @@ class GamebryoSaveGame : public MOBase::ISaveGame
 
     /* Read the plugin list */
     QStringList readPlugins(int bytesToIgnore = 0, bool extraData = false,
-                            const QStringList corePlugins = {});
+                            const QStringList& corePlugins = {});
 
     /* Read the light plugin list */
     QStringList readLightPlugins(int bytesToIgnore = 0, bool extraData = false,
-                                 const QStringList corePlugins = {});
+                                 const QStringList& corePlugins = {});
 
     /* Read the medium plugin list */
     QStringList readMediumPlugins(int bytesToIgnore = 0, bool extraData = false,
-                                  const QStringList corePlugins = {});
+                                  const QStringList& corePlugins = {});
 
     void close();