Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate device/moddable-* #33

Conversation

stc1988
Copy link
Collaborator

@stc1988 stc1988 commented Jul 19, 2024

@meganetaaan 以下の翻訳になります。レビューお願いします

  • /documentation/devices/moddable-two.md
  • /documentation/devices/moddable-one.md
  • /documentation/devices/moddable-three.md
  • /documentation/devices/moddable-display.md
  • /documentation/devices/moddable-zero.md
  • /documentation/devices/moddable-four.md

@stc1988 stc1988 requested a review from meganetaaan July 19, 2024 14:50
@phoddie
Copy link
Contributor

phoddie commented Jul 19, 2024

Great work. But you may have missed one. ;)

@stc1988
Copy link
Collaborator Author

stc1988 commented Jul 20, 2024

@phoddie
Great news! I just created a merge request for the latest release(#34), so I'll work on it afterward.

Copy link
Collaborator

@meganetaaan meganetaaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

軽微な修正とコメントがあります 🙏

documentation/devices/moddable-display.md Outdated Show resolved Hide resolved
documentation/devices/moddable-display.md Outdated Show resolved Hide resolved
documentation/devices/moddable-four.md Outdated Show resolved Hide resolved
documentation/devices/moddable-one.md Show resolved Hide resolved
@stc1988
Copy link
Collaborator Author

stc1988 commented Jul 29, 2024

@meganetaaan 確認ありがとうございます。指摘対応しました

Copy link
Collaborator

@meganetaaan meganetaaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

@meganetaaan meganetaaan merged commit ec4f0a3 into Moddable-OpenSource:dev/translate-jp Aug 5, 2024
@stc1988 stc1988 deleted the feature/device_moddable branch August 16, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants