reviewing #1297 Use constant directly instead of number.

Moddable-OpenSource · Jan 22, 2024 · 439ba91 · 439ba91
1 parent aa85473
commit 439ba91
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/build/devices/esp32/targets/m5stack_cores3/manifest.json b/build/devices/esp32/targets/m5stack_cores3/manifest.json
@@ -106,7 +106,7 @@
 			"volume_divider": 1,
 			"i2s": {
 				"num": 1,
-				"slot": 1,
+				"slot": "I2S_STD_SLOT_LEFT",
 				"bitsPerSample": 16,
 				"bck_pin": 34,
 				"lr_pin": 33,

diff --git a/modules/pins/i2s/audioout.c b/modules/pins/i2s/audioout.c
@@ -79,7 +79,7 @@
 		#endif
 	#endif
 	#ifndef MODDEF_AUDIOOUT_I2S_SLOT
-		#define MODDEF_AUDIOOUT_I2S_SLOT 0
+ 		#define MODDEF_AUDIOOUT_I2S_SLOT I2S_STD_SLOT_RIGHT
 	#endif
 #endif
 
@@ -1512,11 +1512,7 @@ void audioOutLoop(void *pvParameter)
 	i2s_config.slot_cfg.slot_mask = I2S_STD_SLOT_BOTH;
 #else
 	i2s_config.slot_cfg.slot_mode = I2S_SLOT_MODE_MONO;
-	#if MODDEF_AUDIOOUT_I2S_SLOT == 1
-		i2s_config.slot_cfg.slot_mask = I2S_STD_SLOT_LEFT;
-	#else
-		i2s_config.slot_cfg.slot_mask = I2S_STD_SLOT_RIGHT;
-	#endif
+	i2s_config.slot_cfg.slot_mask = MODDEF_AUDIOOUT_I2S_SLOT;;
 #endif
 	i2s_config.slot_cfg.ws_pol = false;
 	i2s_config.slot_cfg.bit_shift = false;