Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when compiling QR code example on mac - file missing #1216

Closed
kairos0ne opened this issue Sep 22, 2023 · 3 comments
Closed

Error when compiling QR code example on mac - file missing #1216

kairos0ne opened this issue Sep 22, 2023 · 3 comments

Comments

@kairos0ne
Copy link

Build environment: macOS
Moddable SDK version: 4.1-32-gc5845e51c
Target device: mac

Description
image

@phoddie
Copy link
Collaborator

phoddie commented Sep 23, 2023

Thanks for the report. I'm able to reproduce the error. It looks like fallout from the recent set of manifest improvements. I'll post a fix in the next day or so.

@phoddie
Copy link
Collaborator

phoddie commented Sep 23, 2023

The application manifest at $MODDABLE/examples/data/qrcode/manifest.json should also include $(MODDABLE)/examples/manifest_commodetto.json.With that in place, it builds and runs as expected. I'll commit that and it should be available in this repo in the coming days.

FWIW – manifest_commodetto.json is a required include for projects using Commodetto and Poco directly. For projects using Piu (which uses Commodetto and Poco), it is not necessary to include manifest_commodetto.json as the necessary pieces are included by manifest_piu,json, which is required for projects using Piu.

mkellner pushed a commit that referenced this issue Sep 26, 2023
@phoddie
Copy link
Collaborator

phoddie commented Sep 29, 2023

Fix committed. Closing.

@phoddie phoddie closed this as completed Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants