Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp32 audioin: I2S_COMM_FORMAT_I2S is deprecated #561

Closed
stc1988 opened this issue Feb 13, 2021 · 2 comments
Closed

esp32 audioin: I2S_COMM_FORMAT_I2S is deprecated #561

stc1988 opened this issue Feb 13, 2021 · 2 comments

Comments

@stc1988
Copy link
Contributor

stc1988 commented Feb 13, 2021

Version: 4e7225e
Build environment: Windows
Target: M5stick_c

Steps to Reproduce
Build examples/pins/audioin/waveserver with mcconfig -d -m -p esp32/m5stick_c

I got a build warning below.

C:\Users\satt6\Projects\moddable\modules\pins\audioin\esp32\audioin.c: In function 'xs_audioin':
C:\Users\satt6\Projects\moddable\modules\pins\audioin\esp32\audioin.c:86:5: warning: 'I2S_COMM_FORMAT_I2 ' is deprecated [-Wdeprecated-declarations]
communication_format: (i2s_comm_format_t)(I2S_COMM_FORMAT_I2S | I2S_COMM_FORMAT_I2S_LSB),
^~~~~~~~~~~~~~~~~~~~
In file included from C:\Users\satt6\esp32\esp-idf\components\soc\src\esp32\include/hal/i2s_ll.h:30,
from C:\Users\satt6\esp32\esp-idf\components\soc\include/hal/i2s_hal.h:28,
from C:\Users\satt6\esp32\esp-idf\components\driver\include/driver/i2s.h:24,
from C:\Users\satt6\Projects\moddable\modules\pins\audioin\esp32\audioin.c:33:
C:\Users\satt6\esp32\esp-idf\components\soc\include/hal/i2s_types.h:70:5: note: declared here
I2S_COMM_FORMAT_I2S attribute((deprecated)) = 0x01, /!< I2S communication format I2S, correspond to I2S_COMM_FORMAT_STAND_I2S/
^~~~~~~~~~~~~~~~~~~
C:\Users\satt6\Projects\moddable\modules\pins\audioin\esp32\audioin.c:86:5: warning: 'I2S_COMM_FORMAT_I2S_LSB' is deprecated [-Wdeprecated-declarations]
communication_format: (i2s_comm_format_t)(I2S_COMM_FORMAT_I2S | I2S_COMM_FORMAT_I2S_LSB),
^~~~~~~~~~~~~~~~~~~~
In file included from C:\Users\satt6\esp32\esp-idf\components\soc\src\esp32\include/hal/i2s_ll.h:30,
from C:\Users\satt6\esp32\esp-idf\components\soc\include/hal/i2s_hal.h:28,
from C:\Users\satt6\esp32\esp-idf\components\driver\include/driver/i2s.h:24,
from C:\Users\satt6\Projects\moddable\modules\pins\audioin\esp32\audioin.c:33:
C:\Users\satt6\esp32\esp-idf\components\soc\include/hal/i2s_types.h:72:5: note: declared here
I2S_COMM_FORMAT_I2S_LSB attribute((deprecated)) = 0x02, /!< I2S format LSB, (I2S_COMM_FORMAT_I2S |I2S_COMM_FORMAT_I2S_LSB) correspond to I2S_COMM_FORMAT_STAND_MSB/

I don't know if this is issues, but this is similar to 624057e

@andycarle
Copy link
Member

Thank you for the report. We took care of those for audioout but not audioin, it seems. I'll get the fix there in for our next push.

@stc1988
Copy link
Contributor Author

stc1988 commented Mar 3, 2021

I confirmed with ReleaseMarch 2, 2021.

@stc1988 stc1988 closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants