Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m5StickC mcsim support #856

Closed
wants to merge 5 commits into from

Conversation

wilberforce
Copy link
Contributor

@wilberforce wilberforce commented Feb 23, 2022

Not sure why, but I had to change this to 0000 for it to appear:

sortingTitle: '0000',

The buttons don't seem to trigger the events (same for M5 paper). I'm not sure how the led should be done - just mirrored existing.

@wilberforce
Copy link
Contributor Author

mcconfig -d -m -p sim/m5StickC

image

@mkellner
Copy link
Collaborator

mkellner commented Mar 4, 2022

Hello. It doesn't look right on my machine.

image

The skin file looks like it is the right size, but it appears to be getting scaled in mcsim.

@wilberforce
Copy link
Contributor Author

wilberforce commented Mar 4, 2022

@mkellner

Hello. It doesn't look right on my machine.

I'm building on windows and it's fine for me...

C:\Users\rhys\Projects\moddable\examples\piu\balls>mcconfig -d -m -p sim/m5StickC

image

In your image, 0.png the canvas is 160x80

on the right of the image, the canvas is: 160x80 it's offset 31x44 which is correct. The background image is 256x128
It should be 342x170.

I have no idea where the size 256x128 is coming from? Is something getting cached - I can't find anything else this size.

what happens if you change:
sortingTitle: '0000', to sortingTitle: '0010',

@mkellner
Copy link
Collaborator

mkellner commented Mar 4, 2022

Changing sortingTitle makes no difference.

@wilberforce
Copy link
Contributor Author

@mkellner - what os are you building on?

The skin file looks like it is the right size
The skin file is displayed 256x124 and should be 342x170 - i have no idea why this would occur ? @phoddie ?

What about other orientations?

@phoddie
Copy link
Collaborator

phoddie commented Mar 4, 2022

I don't have a good explanation at the moment. I can try to look later if this isn't sorted out by then.

@mkellner
Copy link
Collaborator

mkellner commented Mar 4, 2022

Interesting.

I see that the images that you've checked in are at 96 pixels-per-inch.

If I make the image at 72 pixels-per-inch it displays properly on Mac.

I first tried on Linux to see if I would encounter the same problem, but I see a different problem there. With the build line mcconfig -d -m -p sim/m5stickC, I get an error:

### Error: './m5stickc/manifest.json': manifest not found!

It appears that the subplatform is being lowercased by the build tools. This is not a problem on MacOS or Windows which typically use a case-insensitive filesystem, but it is a problem on Linux. So, I think we'll have to change the directory name to lower-case m5stickc.

@wilberforce
Copy link
Contributor Author

wilberforce commented Mar 4, 2022

@mkellner
I've just updated with lower case, and now the correct device gets selected too, and dpi to 72 below...

@mkellner
Copy link
Collaborator

mkellner commented Mar 4, 2022

Thank you. Look for it in the next release!

@mkellner mkellner closed this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants