Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pyton][Arena] Add Fairnes plot #373

Merged
merged 2 commits into from
Dec 28, 2020
Merged

[Pyton][Arena] Add Fairnes plot #373

merged 2 commits into from
Dec 28, 2020

Conversation

piotrpiatyszek
Copy link
Member

Adds Fairness Check to Arena module.
Example usage is in notebook https://gist.github.com/piotrpiatyszek/86f3eb5d749c6a9dabcf75ab7f325917

hbaniecki
hbaniecki requested changes Dec 25, 2020
View reviewed changes
Copy link
Member

@hbaniecki hbaniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Could you add a notice about new feature to NEWS.md?

@hbaniecki
Copy link
Member

mentions #368

jakwisn
jakwisn approved these changes Dec 25, 2020
View reviewed changes
Copy link
Member

@jakwisn jakwisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it also on german and other models, seems ok. Great job

hbaniecki
hbaniecki approved these changes Dec 25, 2020
View reviewed changes
Copy link
Member

@hbaniecki hbaniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@pbiecek pbiecek merged commit a22a6da into master Dec 28, 2020
@hbaniecki hbaniecki deleted the python-arena-fairness-plot branch February 22, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakwisn jakwisn jakwisn approved these changes

@hbaniecki hbaniecki hbaniecki approved these changes

@pbiecek pbiecek Awaiting requested review from pbiecek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@piotrpiatyszek @hbaniecki @jakwisn @pbiecek