Skip to content

Commit

Permalink
Merge pull request #86 from ModelOriented/cran_submission
Browse files Browse the repository at this point in the history
CRAN submission
  • Loading branch information
mayer79 authored May 10, 2023
2 parents 3b5d55e + 3615ddb commit 3dc5f29
Show file tree
Hide file tree
Showing 5 changed files with 27 additions and 29 deletions.
6 changes: 3 additions & 3 deletions CRAN-SUBMISSION
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Version: 0.7.0
Date: 2023-04-10 16:20:03 UTC
SHA: 1d5cdf85049baa8819da6a36b1ee91cdf6637a69
Version: 0.8.0
Date: 2023-05-09 17:34:27 UTC
SHA: e2f9b361e5cb79eb0faa79faabceb98a4bd1726a
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: shapviz
Title: SHAP Visualizations
Version: 0.7.1
Version: 0.8.0
Authors@R: c(
person("Michael", "Mayer", , "mayermichael79@gmail.com", role = c("aut", "cre")),
person("Adrian", "Stando", , "adrian.j.stando@gmail.com", role = "ctb")
Expand Down
7 changes: 4 additions & 3 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
# shapviz 0.7.1
# shapviz 0.8.0

## Better connector to {fastshap}
## API improvement

- From Version >0.0.7, `fastshap::explain()` offers the option `shap_only`. To conveniently construct the "shapviz" object, use `shapviz(fastshap::explain(..., shap_only = FALSE))`. This not only passes the SHAP matrix but also the feature data and the baseline. Thanks, Brandon Greenwell!
- For (upcoming) {fastshap} version >0.0.7, `fastshap::explain()` offers the option `shap_only`. To conveniently construct the "shapviz" object, use `shapviz(fastshap::explain(..., shap_only = FALSE))`. This not only passes the SHAP matrix but also the feature data and the baseline. Thanks, Brandon Greenwell!

## Documentation

- Better help files
- Switched from "import ggplot2" to "ggplot2::function" code style
- Vignette "Multiple 'shapviz' objects": Fixed mistake in Random Forest + Kernel SHAP example

# shapviz 0.7.0
Expand Down
39 changes: 18 additions & 21 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,38 +1,35 @@
# Re-Submission of {shapviz} 0.7.0
# {shapviz} 0.8.0

This second resubmission removes non-standard file (sorry, my bad!)
Hello CRAN team

# Re-Submission of {shapviz} 0.7.0
- {shapviz} will work more smoothly for upcoming {fastshap} versions. I did this change together with the {fastshap} maintainer (Brandon Greenwell).
- Better help files
- Switched from "import ggplot2" to "ggplot2::function" code style

This re-submission fixes non-standard links in the new vignette (and the README).

## Original message

Dear CRAN team.

- {shapviz} can now deal with multiclass models or SHAP values of multiple models. Hurray ;).
- Many additional features
- New contributor
- Additional vignette
- New home: github/ModelOriented/shapviz

## Checks
## Checks look good

### check(manual = TRUE, cran = TRUE)

- WARNING: 'qpdf' is needed for checks on size reduction of PDFs
- Note: unable to verify current time
* checking for future file timestamps ... NOTE
unable to verify current time

### check_rhub()
* checking HTML version of manual ... NOTE
Skipping checking HTML validation: no command 'tidy' found

### check_rhub(): Some usual notes...

* checking package dependencies ... NOTE
'h2o', 'lightgbm'
Packages which this enhances but not available for checking:
'fastshap', 'h2o', 'lightgbm'
* checking HTML version of manual ... NOTE
Skipping checking math rendering: package 'V8' unavailable
* checking for non-standard things in the check directory ... NOTE
Found the following files/directories:
''NULL''
* checking for detritus in the temp directory ... NOTE
Found the following files/directories:
'lastMiKTeXException'

### check_win_devel()

Status: OK

2 changes: 1 addition & 1 deletion packaging.R
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ library(usethis)
use_description(
fields = list(
Title = "SHAP Visualizations",
Version = "0.7.1",
Version = "0.8.0",
Description = "Visualizations for SHAP (SHapley Additive exPlanations),
such as waterfall plots, force plots, various types of importance plots,
dependence plots, and interaction plots.
Expand Down

0 comments on commit 3dc5f29

Please sign in to comment.