Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction heuristic arguments #125

Merged
merged 7 commits into from
Jan 1, 2024
Merged

Interaction heuristic arguments #125

merged 7 commits into from
Jan 1, 2024

Conversation

mayer79
Copy link
Collaborator

@mayer79 mayer79 commented Dec 28, 2023

This PR adds arguments to potential_interactions() and sv_dependence() to control the interaction heuristic used to select color features.

Status:

  • Add argument nbins = NULL to potential_interactions()
  • Switch to R-squared adjusted
  • Add argument color_num = TRUE to potential_interactions()
  • Add argument scale to potential_interactions() that allows multiplication with SHAP variance
  • Add argument adjusted = FALSE
  • Add all new arguments to sv_dependence().
  • Update NEWS
  • Unit tests for potential_interactions()

This is a step towards #119

@mayer79 mayer79 changed the title WIP: Interaction heuristic arguments Interaction heuristic arguments (WIP, do not merge) Dec 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c2cdb30) 97.36% compared to head (b32f747) 97.39%.

❗ Current head b32f747 differs from pull request most recent head 785d9ee. Consider uploading reports for the commit 785d9ee to get more accurate results

Files Patch % Lines
R/potential_interactions.R 98.18% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   97.36%   97.39%   +0.02%     
==========================================
  Files          11       12       +1     
  Lines         798      844      +46     
==========================================
+ Hits          777      822      +45     
- Misses         21       22       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mayer79 mayer79 changed the title Interaction heuristic arguments (WIP, do not merge) Interaction heuristic arguments Jan 1, 2024
@mayer79 mayer79 merged commit a5f2fac into main Jan 1, 2024
7 checks passed
@mayer79 mayer79 deleted the interaction-heuristic branch January 1, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants