Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requested Features - Personalisation #1217

Merged
merged 23 commits into from
Nov 11, 2024

Conversation

manstheram
Copy link
Contributor

@manstheram manstheram commented Aug 14, 2023

This pull-request includes:

  • smaller lock flyouts in general (less space is wasted)
  • vertical volume bars
  • better inactive controls
  • fixed start-up task
  • and icon only lock flyouts.
    This is finished. @Samuel12321

@Samuel12321 Samuel12321 self-requested a review August 15, 2023 09:49
@Samuel12321 Samuel12321 added this to the 0.10 milestone Aug 15, 2023
@Samuel12321 Samuel12321 linked an issue Aug 15, 2023 that may be closed by this pull request
@Samuel12321 Samuel12321 added the Enhancement New feature or request label Aug 15, 2023
@Samuel12321 Samuel12321 linked an issue Aug 15, 2023 that may be closed by this pull request
@manstheram manstheram marked this pull request as draft August 17, 2023 14:10
@manstheram manstheram changed the title Adds individual icons for lock keys Requested Features - Personalisation Aug 17, 2023
@manstheram manstheram marked this pull request as ready for review August 18, 2023 21:03
@Samuel12321 Samuel12321 linked an issue Aug 18, 2023 that may be closed by this pull request
@Samuel12321
Copy link
Member

Thanks @manstheram , will review test and merge this evening.

@manstheram
Copy link
Contributor Author

manstheram commented Aug 19, 2023

I just noticed that the vertical volume bar setting doesn't save when you reopen the app, but the consise lock flyouts one does, so I gotta fix that.
Edit - Fixed that.

Copy link
Member

@Samuel12321 Samuel12321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @manstheram , Thanks for the PR.
Just found a few issues that need to be resolved before merging.

  • Flyout axis setting is currently reversed
  • Lock icons are not following flyout theme, so are barely visible when flyout theme is dark.
  • Lock icons really need to be Segoe MDL2 or Segoe UI for consistency within both ModernFlyouts and Windows its self

@manstheram
Copy link
Contributor Author

Lock icons really need to be Segoe MDL2 or Segoe UI for consistency within both ModernFlyouts and Windows its self

About that, there are no lock icons for each type of lock in those fonts, which is why I had to use custom ones. ShankarBUS tried to do a similar thing, however he could only get blurry images since he was not using svgs - #63

But I can't create a neat icon. They looked blurry when scaled. WPF doesn't support SVGs. There were too many issues with this.
I guess just showing the lock icon will be enough for now

I got around the blurry state by using a converter "SvgtoXaml" to make svgs into shapes that I can use in WPF. https://github.com/BerndK/SvgToXaml

The flyouts icon wouldn't update cause I used a resource file, so instead, I have all of them loaded as separate images in the UserControl where I needed to show them and then hide and show as required. Sure, it's messy, but that's cause .NET is bad.
@manstheram
Copy link
Contributor Author

manstheram commented Aug 20, 2023

I have now added those first two changes you needed, but the third one can't be done cause there are no icons to use from those fonts. It should be finished now. @Samuel12321

Copy link
Contributor Author

@manstheram manstheram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be ready to use.

Certain laptops are incorrectly reporting the min/max values they are capable of so I added a mode that just sets them to be 0 and 100 respectively.
The minimum height didn't change depending on the top bar, now it does and aligns to the background of the session panel properly.
manstheram and others added 2 commits June 20, 2024 17:45
For the 22H2 Volume OSD as I had incorrectly checked for 21H2 by accident.
@Samuel12321 Samuel12321 merged commit ea30f97 into ModernFlyouts-Community:main Nov 11, 2024
1 check passed
Samuel12321 added a commit that referenced this pull request Nov 12, 2024
- updated .net to 9 preview
- fixed crash on launch
- integrated fixes from #1217
- Updated Nuget Packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
2 participants