New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all the things #9

Merged

Moderocky merged 2 commits into Moderocky:master from bluelhf:master

Jun 19, 2022

Contributor

bluelhf commented Jun 18, 2022 •

edited

Loading

This pull request fixes several issues related to unimplemented or incorrect code:

It makes providing a return type for syntax elements mandatory
It adds return type definitions to existing syntax, and fixes incorrect ones
It temporarily removes requiresMainThread, which is currently not implemented
It allows ExprFunctionExternal to retain type information from pre-compile time to better differentiate between methods of the same name with different parameter types

bluelhf added 2 commits

June 18, 2022 22:52


          fix: return types

059ebdf


          fix: use expected return types to specify external function

df3024e

bluelhf changed the title ~~Add/fix several return types~~ Fix ExprFunctionExternal type specification

bluelhf changed the title ~~Fix ExprFunctionExternal type specification~~ FIx all the things

bluelhf changed the title ~~FIx all the things~~ Fix all the things

Contributor Author

bluelhf commented Jun 19, 2022

Moderocky merged commit 03851a2 into Moderocky:master

bluelhf mentioned this pull request

Implement requiresMainThread #8

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet