Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm ci gives "only-allow pnpm" but not npm i #7

Closed
Jwiggiff opened this issue Nov 4, 2022 · 6 comments · Fixed by #12
Closed

npm ci gives "only-allow pnpm" but not npm i #7

Jwiggiff opened this issue Nov 4, 2022 · 6 comments · Fixed by #12

Comments

@Jwiggiff
Copy link

Jwiggiff commented Nov 4, 2022

I'm trying to setup a github action to deploy my vite site in which I use your plugin. I've been using npm locally and has been working completely fine. However, when I run the github action and run npm ci it gives me an error telling me I must use pnpm in this project, even though I use npm locally.

georgkrause added a commit to georgkrause/vite-plugin-yaml that referenced this issue Nov 9, 2022
georgkrause added a commit to georgkrause/vite-plugin-yaml that referenced this issue Dec 1, 2022
georgkrause added a commit to georgkrause/vite-plugin-yaml that referenced this issue Dec 1, 2022
georgkrause added a commit to georgkrause/vite-plugin-yaml that referenced this issue Dec 1, 2022
@tonyduanesmith
Copy link

Just a heads up, I had this issue and noticed the node versions were different. Node 14 I get this issue Node 16 I don't

@arildm
Copy link

arildm commented Dec 22, 2022

I'm using yarn install and I'm also seeing the same difference between Node 14 and 16.

@georgkrause I don't see how changing it to devPreinstall could be a good fix. If I understand correctly, only pnpm recognizes that lifecycle script, so it makes the line completely pointless.

@georgkrause
Copy link

@arildm I don't know what this line is good for anyways, but if only pnpm picks up this line, it at least doesn't make all other package managers not work anymore, while having it in preinstall blocks them all. But I'm fine with another idea, if you have one :)

@tonyketcham
Copy link
Collaborator

tonyketcham commented Dec 24, 2022

If I understand correctly, only pnpm recognizes that lifecycle script, so it makes the line completely pointless.

Great point @arildm you're totally right that it'll become useless if it's only detected by pnpm

@arildm
Copy link

arildm commented Dec 27, 2022

@tonyketcham So what would be a good fix though? Adding that line seems to be disrupting npm and yarn usage. My suggestion would be to remove the line, but I'm not exactly sure what effect that would have.

@tonyketcham
Copy link
Collaborator

This has been resolved in v1.0.4!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants