Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important Semicolon #34

Merged
merged 7 commits into from
Sep 27, 2022
Merged

Important Semicolon #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4b5491d
onchange patch
mouse0270 Sep 26, 2022
f7219aa
Update CHANGELOG.md
mouse0270 Sep 26, 2022
ae1d07e
Update module.json
mouse0270 Sep 26, 2022
ba54854
v1.4.5
mouse0270 Sep 26, 2022
0206202
Update CHANGELOG.md
mouse0270 Sep 26, 2022
a810b94
Important semicolon
mouse0270 Sep 26, 2022
144e4dd
Merge branch 'master' of https://github.com/mouse0270/fvtt-find-the-c…
mouse0270 Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# v1.4.6
- Added semicolon to end of `await game.settings.set(...)` was causing reload logic to error

# v1.4.5
- Moved window reload logic to `await` instead of core settings `onchange` event. Fixes incompatibility between MM+ and Ftc

Expand Down
4 changes: 2 additions & 2 deletions js/find-the-culprit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ async function deactivationStep(chosenModules = []) {
await game.settings.set(moduleName, "modules", currSettings);
}

await game.settings.set("core", ModuleManagement.CONFIG_SETTING, original)
await game.settings.set("core", ModuleManagement.CONFIG_SETTING, original);
(foundry.utils.debouncedReload ?? window.location.reload)(); // Temporarily required by foundryvtt/foundryvtt#7740
}

Expand All @@ -357,7 +357,7 @@ async function reactivateModules() {
);
for (let mod in curr.original) original[mod] = curr.original[mod];

await game.settings.set("core", ModuleManagement.CONFIG_SETTING, original)
await game.settings.set("core", ModuleManagement.CONFIG_SETTING, original);
(foundry.utils.debouncedReload ?? window.location.reload)(); // Temporarily required by foundryvtt/foundryvtt#7740
}

Expand Down
4 changes: 2 additions & 2 deletions module.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"bugs": "https://github.com/Moerill/fvtt-find-the-culprit/issues",
"changelog": "https://github.com/Moerill/fvtt-find-the-culprit/blob/master/CHANGELOG.md",
"flags": {},
"version": "1.4.5",
"version": "1.4.6",
"compatibility": {
"minimum": "9",
"verified": "10"
Expand All @@ -32,6 +32,6 @@
"dependencies": [],
"socket": false,
"manifest": "https://raw.githubusercontent.com/Moerill/fvtt-find-the-culprit/master/module.json",
"download": "https://github.com/Moerill/fvtt-find-the-culprit/releases/download/v1.4.5/v1.4.5.zip",
"download": "https://github.com/Moerill/fvtt-find-the-culprit/releases/download/v1.4.6/v1.4.6.zip",
"protected": false
}