Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local notification permission #107

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

Joe3112
Copy link
Contributor

@Joe3112 Joe3112 commented Jul 1, 2024

Hi @MohamedRejeb!
Thanks for the awesome library.
For my application I require local notification support, was a breeze to implement.

Copy link
Owner

@MohamedRejeb MohamedRejeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This should be mentioned in the docs with other permissions: https://mohamedrejeb.github.io/Calf/permissions/
https://github.com/MohamedRejeb/Calf/blob/main/docs/permissions.md

Please add what user needs to add in the AndroidManifest.xml and Info.plist

Thanks for your contribution!

@Joe3112
Copy link
Contributor Author

Joe3112 commented Jul 2, 2024

Done!

@Joe3112 Joe3112 requested a review from MohamedRejeb July 2, 2024 09:12
Copy link
Owner

@MohamedRejeb MohamedRejeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MohamedRejeb MohamedRejeb merged commit de4e950 into MohamedRejeb:main Jul 2, 2024
1 check passed
@Joe3112 Joe3112 deleted the feature/notifications branch July 2, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants