-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Web-View from UI Package #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md
Update README.md
Add permissions support
Fix Typo in README.md: Change 'FilePickerType' to 'FilePickerFileType'
Add geo support
Update version to 0.3.0
Update Readme.md
don't give default value to title + headline in AdaptiveDatePicker for Android
Because of JavaFX Errors
If you agree for next release: Breaking Changes:WebView removed from UI: // For Adaptive WebView components
api("com.mohamedrejeb.calf:calf-ui-webview:0.3.0") |
Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review it, I am not sure about adding CocoaPods/Regular Framework dependency is because of WebView or not, If it's true, the documents should be change too.
Because of JavaFX usage in WebView module, and adding JavaFX and coroutines only because of WebView, I separated WebView to another package:
api("com.mohamedrejeb.calf:calf-ui-webview:0.3.0")