Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Web-View from UI Package #46

Merged
merged 20 commits into from
Jun 20, 2024

Conversation

Shahriyar13
Copy link
Contributor

@Shahriyar13 Shahriyar13 commented Dec 7, 2023

Please review it, I am not sure about adding CocoaPods/Regular Framework dependency is because of WebView or not, If it's true, the documents should be change too.

Because of JavaFX usage in WebView module, and adding JavaFX and coroutines only because of WebView, I separated WebView to another package:

api("com.mohamedrejeb.calf:calf-ui-webview:0.3.0")

com.sun.javafx.application.PlatformImpl startup
WARNING: Unsupported JavaFX configuration: classes were loaded from 'unnamed module @82702de'
Exception in thread "JavaFX Application Thread @coroutine#1" java.lang.IllegalArgumentException: Not on Main thread, current thread is: Thread[#24,JavaFX Application Thread @coroutine#1,5,system]

MohamedRejeb and others added 20 commits September 24, 2023 17:23
Fix Typo in README.md: Change 'FilePickerType' to 'FilePickerFileType'
don't give default value to title + headline in AdaptiveDatePicker for Android
Because of JavaFX Errors
@Shahriyar13
Copy link
Contributor Author

If you agree for next release:

Breaking Changes:

WebView removed from UI:

// For Adaptive WebView components
api("com.mohamedrejeb.calf:calf-ui-webview:0.3.0")

@MohamedRejeb MohamedRejeb changed the base branch from main to 0.1.x June 20, 2024 20:08
@MohamedRejeb MohamedRejeb changed the base branch from 0.1.x to 0.2.x June 20, 2024 20:08
@MohamedRejeb MohamedRejeb changed the base branch from 0.2.x to 0.3.x June 20, 2024 20:08
@MohamedRejeb MohamedRejeb changed the base branch from 0.3.x to 0.4.x June 20, 2024 20:08
@MohamedRejeb MohamedRejeb changed the base branch from 0.4.x to webview June 20, 2024 20:09
@MohamedRejeb
Copy link
Owner

Thanks for your contribution.
Sorry for taking too much to accept this.

@MohamedRejeb MohamedRejeb merged commit f0eaf8f into MohamedRejeb:webview Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants