Use PHPicker if file type is image on iOS #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedRejeb
approved these changes
Jan 8, 2024
|
Looks good! Thanks for your contribution. |
|
Yes, I think it would be a good idea if you can add a new screen with a pdf picker to have both pickers in the sample. |
MohamedRejeb
approved these changes
Jan 8, 2024
|
Hey @MohamedRejeb 👋🏻 By the way, I think I'm not able to merge the branch so feel free to do it when required! |
|
I'll merge it, I was just waiting for the build result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35
I just copied the logic you previously had to use the PHPicker, but it's running only if the desired file type is an image.
Let me know if something else is required. Maybe a different screen in the sample to select an image or a pdf and thus check that the document picker is correctly run would be good.