Add some extra utilities, assorted fixes and cleanups #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gegy
force-pushed
the
utilities-and-fixes
branch
from
279c76b to
a463370
Compare
boq
reviewed
Mar 18, 2024
src/main/java/com/mojang/serialization/codecs/KeyDispatchCodec.java
Outdated
Show resolved
Hide resolved
Panda4994
approved these changes
Mar 19, 2024
boq
approved these changes
Mar 19, 2024
Co-authored-by: boq <boq@mojang.com>
Co-authored-by: boq <boq@mojang.com>
…eMapCodec Fixes MC-268882.
This avoids the need for special treatment of MapCodecCodec. Any caller desiring the old behavior of the `value` sub-field should construct a `fieldOf("value")` MapCodec.
Gegy
force-pushed
the
utilities-and-fixes
branch
from
1440716 to
4486b69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly made up of extractions from
ExtraCodecsor extracting common usage patterns.Best to review commit-by-commit.