Support defaultReturnValue in useFacetCallback #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is to make it easier to use callbacks constructed via the hook
useFacetCallback
to interoperate with other libraries.As an example, before this change we will get a type error if we plan to use the resulting callback as a prop to a component that expects a string as a return type:
The new
defaultReturnValue
prop allow us to have a callback that can never returnNO_VALUE
.