Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new facet function
createFacetContext
Which can be used to create a context that holds a facet with the type
Facet
instead ofWritableFacet
.NOTE: Writable facets you provide into the context provider are still technically writable as you can call them with
.set()
however the function will change the type to show that the facet doesn't have a setter internally (in reality it does).This hopefully will help steer consumers away from setting facets arbitrarily using
createFacet
andfacet.set()
instead of sticking to more conventional react methods and oruseFacetX
hooksthis turns code like this
into
In the first instance the Facet was a WritableFacet and was gonna stay that way no matter what, in the 2nd instance it is no longer a WritableFacet, which hopefully should offer a cleaner method of writing a context holding a facet for it's property of not triggering reconciliation and not for it's property of being a writable store of value.