Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Archive page #260

Merged
merged 13 commits into from
Nov 8, 2022
Merged

feat: add Archive page #260

merged 13 commits into from
Nov 8, 2022

Conversation

Anish-Sarawgi
Copy link
Member

@Anish-Sarawgi Anish-Sarawgi commented Sep 9, 2022

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • I have added necessary documentation (if appropriate)

Linked Issues

resolves #170

Description

Archive-page

Please refer the above image along with the commits.

❤️Thank you!

Post merge checklist

  • Follow steps from the guidelines for contributing to this repository.
  • If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

@sambit-sankalp sambit-sankalp added enhancement New feature or request wip Work In Progress labels Sep 10, 2022
@rutajdash
Copy link
Member

@120EE0692 @sambit-sankalp please perform a preliminary review.

@120EE0692
Copy link
Member

@Anish-Sarawgi fix the alignment issue and also add the all option
image

Copy link
Contributor

@sambit-sankalp sambit-sankalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anish-Sarawgi ,
This PR looks good, but a few changes are suggested. Make sure to commit them.

client/src/pages/archive.jsx Outdated Show resolved Hide resolved
client/src/pages/archive.jsx Outdated Show resolved Hide resolved
client/src/pages/archive.jsx Outdated Show resolved Hide resolved
client/src/pages/archive.jsx Outdated Show resolved Hide resolved
client/src/pages/archive.jsx Outdated Show resolved Hide resolved
client/src/screens/Archive.jsx Outdated Show resolved Hide resolved
client/src/screens/Archive.jsx Outdated Show resolved Hide resolved
client/src/screens/Archive.jsx Outdated Show resolved Hide resolved
client/src/screens/Archive.jsx Outdated Show resolved Hide resolved
@sambit-sankalp
Copy link
Contributor

Adding to the above changes,

  • Make sure to link the issue you are fixing or the feature you are developing while sending PRs.
  • Attach a screenshot for the solution you have provided.

@Anish-Sarawgi Anish-Sarawgi deleted the feat/Anish-Sarawgi/01 branch October 1, 2022 12:39
@Anish-Sarawgi Anish-Sarawgi restored the feat/Anish-Sarawgi/01 branch October 1, 2022 12:40
@Anish-Sarawgi Anish-Sarawgi reopened this Oct 1, 2022
@Anish-Sarawgi Anish-Sarawgi requested review from sambit-sankalp and removed request for 120EE0692 October 1, 2022 19:33
Copy link
Contributor

@sambit-sankalp sambit-sankalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anish-Sarawgi ,
Changes are good, but the alignment issue is still not fixed. Please align the page contents with the page's header as previously @120EE0692 said.

@Anish-Sarawgi
Copy link
Member Author

@Anish-Sarawgi fix the alignment issue and also add the all option image

@120EE0692 I have made the required changes. Please review it once.

@120EE0692 120EE0692 requested a review from rutajdash October 4, 2022 08:09
@120EE0692 120EE0692 added the hacktoberfest The Hacktober Fest Label label Oct 4, 2022
@sambit-sankalp sambit-sankalp self-requested a review October 8, 2022 17:22
@rutajdash rutajdash merged commit b1a5dc5 into Monday-Morning:main Nov 8, 2022
@Anish-Sarawgi Anish-Sarawgi deleted the feat/Anish-Sarawgi/01 branch November 9, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest The Hacktober Fest Label wip Work In Progress
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat(guide): create Archive page
4 participants