-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add exception handling to rendering #319
Conversation
@Shurtu-gal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to use the 500 error inside the header/head tags? We don't want any page to go without having some headers being passed.
* feat(home): integrate photostory and witsdom * style(home): banner of photostory and witsdom
Yes, it's done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Custom error boundaries left for future scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shurtu-gal if there is no prettier issue then do the following steps
|
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Linked Issues
Fixes #314
Description
Please describe your pull request.
❤️Thank you!
Post merge checklist