Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add exception handling to rendering #319

Merged
merged 10 commits into from
Dec 11, 2022
Merged

fix: add exception handling to rendering #319

merged 10 commits into from
Dec 11, 2022

Conversation

Shurtu-gal
Copy link
Member

@Shurtu-gal Shurtu-gal commented Nov 22, 2022

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
  • Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • I have added necessary documentation (if appropriate)

Linked Issues

Fixes #314

Description

Please describe your pull request.

❤️Thank you!

Post merge checklist

  • Follow steps from the guidelines for contributing to this repository.
  • If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

@120EE0692 120EE0692 self-requested a review November 25, 2022 08:35
@120EE0692 120EE0692 added enhancement New feature or request bugfix Some Bug was Fixed labels Nov 25, 2022
@120EE0692
Copy link
Member

120EE0692 commented Nov 25, 2022

@Shurtu-gal
I think this will show page 404 even in case of error.
Please make sure in case of some error it shows page 500

@Shurtu-gal Shurtu-gal requested a review from 120EE0692 December 6, 2022 17:45
client/src/pages/article/[...article].jsx Outdated Show resolved Hide resolved
client/src/pages/index.jsx Outdated Show resolved Hide resolved
@Shurtu-gal Shurtu-gal requested a review from 120EE0692 December 6, 2022 18:07
@Shurtu-gal Shurtu-gal requested a review from 120EE0692 December 9, 2022 05:19
@120EE0692 120EE0692 requested a review from rutajdash December 9, 2022 16:40
Copy link
Member

@rutajdash rutajdash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to use the 500 error inside the header/head tags? We don't want any page to go without having some headers being passed.

client/src/pages/expressions/[...subCategory].jsx Outdated Show resolved Hide resolved
@Shurtu-gal
Copy link
Member Author

Would it be possible to use the 500 error inside the header/head tags? We don't want any page to go without having some headers being passed.

Yes, it's done.

@Shurtu-gal Shurtu-gal requested a review from rutajdash December 11, 2022 07:17
Copy link
Member

@rutajdash rutajdash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom error boundaries left for future scope.

Copy link
Member

@rutajdash rutajdash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Please fix these issues

@120EE0692
Copy link
Member

image

Please fix these issues

@Shurtu-gal if there is no prettier issue then do the following steps

  1. rename the file 500.jsx to something else, commit and push the changes.
  2. then rename it back to 500.jsx, then commit and push.

@rutajdash rutajdash merged commit 728fe76 into Monday-Morning:main Dec 11, 2022
@Shurtu-gal Shurtu-gal deleted the fix/render branch December 11, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Some Bug was Fixed enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat: add error catch in all render methods
4 participants