Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create individual Photostory page #331

Merged
merged 12 commits into from
Dec 20, 2022
Merged

feat: create individual Photostory page #331

merged 12 commits into from
Dec 20, 2022

Conversation

Anish-Sarawgi
Copy link
Member

@Anish-Sarawgi Anish-Sarawgi commented Dec 2, 2022 •
edited
Loading

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
  • Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • I have added necessary documentation (if appropriate)

Linked Issues

Fixes #322

Description

Desktop View

Screenshot (18)

Mobile View

Screenshot (19)

Please describe your pull request.

❤️Thank you!

Post merge checklist

  • Follow steps from the guidelines for contributing to this repository.
  • If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

@120EE0692 120EE0692 added the enhancement New feature or request label Dec 2, 2022
@120EE0692 120EE0692 self-requested a review December 2, 2022 08:40
@120EE0692
Copy link
Member

@Anish-Sarawgi the UI/UX is not matching.
image

The height of side images should be smaller as compare to the image in the center.

120EE0692
120EE0692 requested changes Dec 11, 2022
View reviewed changes
client/src/pages/photostory/[...photostory].jsx Outdated Show resolved Hide resolved
client/src/pages/photostory/[...photostory].jsx Outdated Show resolved Hide resolved
120EE0692
120EE0692 requested changes Dec 11, 2022
View reviewed changes
Copy link
Member

@120EE0692 120EE0692 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Anish-Sarawgi make code changes so that photo story in the right redirects to photostory page and not to article page.

120EE0692
120EE0692 requested changes Dec 11, 2022
View reviewed changes
Copy link
Member

@120EE0692 120EE0692 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anish-Sarawgi
image
tags must be dynamic.

120EE0692
120EE0692 requested changes Dec 11, 2022
View reviewed changes
Copy link
Member

@120EE0692 120EE0692 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@undo or comments these changes.

120EE0692
120EE0692 requested changes Dec 11, 2022
View reviewed changes
client/src/assets/placeholder/photostory.js Outdated Show resolved Hide resolved
client/src/pages/photostory/[...photostory].jsx Outdated Show resolved Hide resolved
@120EE0692 120EE0692 requested a review from rutajdash December 12, 2022 16:04
rutajdash
rutajdash requested changes Dec 14, 2022
View reviewed changes
Copy link
Member

@rutajdash rutajdash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anish-Sarawgi please screenshots of the latest UI designed.

client/src/components/widgets/PhotoCarousel.js Outdated Show resolved Hide resolved
@Anish-Sarawgi
Copy link
Member Author

@Anish-Sarawgi please screenshots of the latest UI designed.

I have added the screenshots in the PR description now.

@rutajdash rutajdash merged commit 8cf9578 into Monday-Morning:main Dec 20, 2022
@Anish-Sarawgi Anish-Sarawgi deleted the feat/#322/photostory-individual branch December 20, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rutajdash rutajdash rutajdash approved these changes

@120EE0692 120EE0692 120EE0692 approved these changes

Assignees

@Anish-Sarawgi Anish-Sarawgi

Labels
enhancement New feature or request
Projects
Project Infinity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: create individual photostory page
3 participants
@Anish-Sarawgi @120EE0692 @rutajdash