Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #2356 #1

Merged
merged 1 commit into from
Jun 9, 2017
Merged

fix #2356 #1

merged 1 commit into from
Jun 9, 2017

Conversation

pouriaalmassi
Copy link

Description

When floor(10.0 * intervalMagnitude) is 0.0, we use the old value to avoid crash at axis.decimals = Int(ceil(-log10(interval)))

ChartsOrg#2377

@liuxuan30
fix ChartsOrg#2356
5092512 
When `floor(10.0 * intervalMagnitude)` is 0.0, we use the old value to avoid crash at `axis.decimals = Int(ceil(-log10(interval)))`
vincent-peng
vincent-peng approved these changes Jun 9, 2017
View reviewed changes
Copy link

@vincent-peng vincent-peng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fingers crossed!

@pouriaalmassi pouriaalmassi merged commit 285bd3c into master Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincent-peng vincent-peng vincent-peng approved these changes

Assignees

@vincent-peng vincent-peng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pouriaalmassi @vincent-peng @liuxuan30