Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure log messages are written in order #46

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Ensure log messages are written in order #46

merged 1 commit into from
Nov 22, 2024

Conversation

Banane9
Copy link
Member

@Banane9 Banane9 commented Nov 22, 2024

Closes #45

@Banane9 Banane9 added the bug Something isn't working label Nov 22, 2024
@Banane9 Banane9 requested a review from Nytra November 22, 2024 20:28
@Nytra
Copy link
Contributor

Nytra commented Nov 22, 2024

Did you test this?

@Banane9
Copy link
Member Author

Banane9 commented Nov 22, 2024

It launches and logs, if that's what you're asking 😅

I didn't see anything obviously out of order at least (and that shouldn't be possible anymore)

Nytra
Nytra approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@Nytra Nytra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it seems to work

@Banane9 Banane9 merged commit 4ab3717 into master Nov 22, 2024
@Banane9 Banane9 deleted the bug/out-of-order-log-messages branch November 22, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nytra Nytra Nytra approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sometimes log messages appear out of order
2 participants
@Banane9 @Nytra