Add support to attach multiple disks #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now module accepts a dynamic disk list and attach each of them as a volume into the domain
|
Hi @chrodriguez , it looks good! Just please change the version in the readme to 1.8.0. Thanks |
Now code examples references latest tag
|
Ok! I've just updated readme versiosn |
|
cool. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found very useful to create a VM with more than one disk. Now module accepts a dynamic disk list to be attached. I've changed README examples with version 1.7.1 (thining new release can be 1.7.1), but if you prefer other semantic version number please feel free to ask me to change it.