Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to the now deprecated template provider #19

Conversation

tuxillo
Copy link
Contributor

@tuxillo tuxillo commented Jan 18, 2023

As mentioned in issue #18 , the template provider is deprecated.

This PR removes references to it and tries to adapt the code to the new recommendations. There is some code duplication that I'm unsure how to remove.

@tuxillo tuxillo changed the base branch from main to develop January 19, 2023 18:12
@tuxillo tuxillo changed the base branch from develop to main January 19, 2023 18:15
@tuxillo
Copy link
Contributor Author

tuxillo commented Jan 19, 2023

After reading in CONTRIBUTING.md that the PRs go to the developbranch, I changed the merge base but it's not up to date so I changed it again to main. Let me know if I should do otherwise.

@MonolithProjects MonolithProjects changed the base branch from main to develop January 29, 2023 20:17
@MonolithProjects
Copy link
Owner

Hi @tuxillo, thanks for this PR! I will merge it to develop (sry for that mess with not to be up to date ) and maybe tomorrow play with the code duplication (or maybe not 😅).

@MonolithProjects MonolithProjects merged commit 9124946 into MonolithProjects:develop Jan 29, 2023
@MonolithProjects MonolithProjects mentioned this pull request Feb 5, 2023
@tuxillo tuxillo deleted the Remove-template-provider-usage branch February 27, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants