Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new variables and change defaults for some variables #9

Merged
merged 9 commits into from
Jan 24, 2022

Conversation

chrodriguez
Copy link
Contributor

First of all, I have to say thank you for your work! It is the same module I was trying to write, and for this reason I am trying to commit some changes that can be useful for other users.

My changes propose making local_admin and ssh_private_key optiona values. And base volume resource creating be optional depending on other new variables.

When trying to use this module with my own configuration, I found myself with some limitations that think can be usefull to add and make this module more reusable:

  • Storage management: added two variables to use existing base images an not always uploading a base image
    • base_pool_name: define an existing pool name
    • base_volume_name: define an existing base volume name
  • Local user management: when this variable is empty do not create a local_user. Changed default value to make this a default behaviour.
  • Test vm connection: in almost all cases users would use their default private key that may be loaded with ssh-agent. So default behaviour seems to be a null value, but allow to define a different one.

MonolithProjects and others added 9 commits February 7, 2021 16:05
When trying to use this module with my own configuration, I found myself
with some needs that think can be usefull to make this module more
reusable:

* Storage management: added two variables to use existing base images an
  not always uploading a base image
  * base_pool_name: define an existing pool name
  * base_volume_name: define an existing base volume name
* Local user management: when this variable is empty do not create a
  local_user. Changed default value to make this a default behaviour.
* Test vm connection: in almost all cases users would use their default
  private key, that may be loaded with ssh-agent. So default behaviour
  seems to be null value, but allow to define a different value
Explain changed values and added variables
@MonolithProjects
Copy link
Owner

Thanks! lgtm

@MonolithProjects MonolithProjects changed the base branch from main to develop January 24, 2022 15:08
@MonolithProjects MonolithProjects merged commit 8512d70 into MonolithProjects:develop Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants