Skip to content

Commit

Permalink
android-tools: refresh patch
Browse files Browse the repository at this point in the history
WARNING: android-tools-5.1.1.r37-r0 do_patch:
Some of the context lines in patches were ignored. This can lead to incorrectly applied patches.
The context lines in the patches can be updated with devtool:

    devtool modify <recipe>
    devtool finish --force-patch-refresh <recipe> <layer_path>

Then the updated patches and the source tree (in devtool's workspace)
should be reviewed to make sure the patches apply in the correct place
and don't introduce duplicate lines (which can, and does happen
when some of the context is ignored). Further information:
http://lists.openembedded.org/pipermail/openembedded-core/2018-March/148675.html
https://bugzilla.yoctoproject.org/show_bug.cgi?id=10450
Details:
Applying patch preserve-ownership.patch
patching file system/extras/ext4_utils/make_ext4fs_main.c
Hunk openembedded#1 succeeded at 47 with fuzz 2 (offset -2 lines).
Hunk openembedded#2 succeeded at 81 (offset -2 lines).
Hunk openembedded#3 succeeded at 144 (offset -2 lines).
patching file system/extras/ext4_utils/make_ext4fs.c

Now at patch preserve-ownership.patch

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
  • Loading branch information
shr-project authored and akuster committed May 2, 2018
1 parent 9ea20e3 commit 8173679
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 32 deletions.
Original file line number Diff line number Diff line change
@@ -1,19 +1,50 @@
From aa669312a380611d280d126cb509fa282080707e Mon Sep 17 00:00:00 2001
From: Markus Mayer <mmayer@mmayer.net>
Date: Wed, 7 Sep 2016 12:58:47 +0300
Subject: [PATCH] android-tools: add recipe from AOSP tag android-5.1.1_r37

Description: add -o argument to preserve ownership
Author: Markus Mayer <mmayer@mmayer.net>

See also https://android-review.googlesource.com/#/c/100312/

Upstream-Status: Inappropriate

---
system/extras/ext4_utils/make_ext4fs.c | 6 ++++++
system/extras/ext4_utils/make_ext4fs_main.c | 10 ++++++++--
ext4_utils/make_ext4fs.c | 6 ++++++
ext4_utils/make_ext4fs_main.c | 10 ++++++++--
2 files changed, 14 insertions(+), 2 deletions(-)

--- a/system/extras/ext4_utils/make_ext4fs_main.c
+++ b/system/extras/ext4_utils/make_ext4fs_main.c
@@ -49,13 +49,15 @@ extern struct fs_info info;
diff --git a/ext4_utils/make_ext4fs.c b/ext4_utils/make_ext4fs.c
index 2f89ae8a..cc41d623 100644
--- a/ext4_utils/make_ext4fs.c
+++ b/ext4_utils/make_ext4fs.c
@@ -68,6 +68,8 @@

#endif

+int preserve_owner = 0;
+
/* TODO: Not implemented:
Allocating blocks in the same block group as the file inode
Hash or binary tree directories
@@ -186,6 +188,10 @@ static u32 build_directory_structure(const char *full_path, const char *dir_path
} else {
dentries[i].mtime = fixed_time;
}
+ if (preserve_owner) {
+ dentries[i].uid = stat.st_uid;
+ dentries[i].gid = stat.st_gid;
+ }
uint64_t capabilities;
if (fs_config_func != NULL) {
#ifdef ANDROID
diff --git a/ext4_utils/make_ext4fs_main.c b/ext4_utils/make_ext4fs_main.c
index a6c5f616..7af0dddf 100644
--- a/ext4_utils/make_ext4fs_main.c
+++ b/ext4_utils/make_ext4fs_main.c
@@ -48,13 +48,15 @@ struct selabel_handle;
extern struct fs_info info;

extern struct selabel_handle* selinux_android_file_context_handle(void);

+extern int preserve_owner;
+
Expand All @@ -28,7 +59,7 @@ Upstream-Status: Inappropriate
fprintf(stderr, " <filename> [<directory>]\n");
}

@@ -81,7 +83,7 @@ int main(int argc, char **argv)
@@ -80,7 +82,7 @@ int main(int argc, char **argv)
struct selinux_opt seopts[] = { { SELABEL_OPT_PATH, "" } };
#endif

Expand All @@ -37,7 +68,7 @@ Upstream-Status: Inappropriate
switch (opt) {
case 'l':
info.len = parse_num(optarg);
@@ -144,6 +146,10 @@ int main(int argc, char **argv)
@@ -143,6 +145,10 @@ int main(int argc, char **argv)
}
#endif
break;
Expand All @@ -48,25 +79,3 @@ Upstream-Status: Inappropriate
case 'v':
verbose = 1;
break;
--- a/system/extras/ext4_utils/make_ext4fs.c
+++ b/system/extras/ext4_utils/make_ext4fs.c
@@ -67,6 +67,8 @@

#endif

+int preserve_owner = 0;
+
/* TODO: Not implemented:
Allocating blocks in the same block group as the file inode
Hash or binary tree directories
@@ -185,6 +187,10 @@ static u32 build_directory_structure(con
} else {
dentries[i].mtime = fixed_time;
}
+ if (preserve_owner) {
+ dentries[i].uid = stat.st_uid;
+ dentries[i].gid = stat.st_gid;
+ }
uint64_t capabilities;
if (fs_config_func != NULL) {
#ifdef ANDROID
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ SRC_URI = " \
file://remove-selinux-android.patch \
file://use-capability.patch \
file://use-local-socket.patch \
file://preserve-ownership.patch \
file://preserve-ownership.patch;patchdir=system/extras \
file://mkbootimg-Add-dt-parameter-to-specify-DT-image.patch \
file://remove-bionic-android.patch \
file://define-shell-command.patch \
Expand Down

0 comments on commit 8173679

Please sign in to comment.