Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol DeSer: Fix subscopes & add SymTypeExpression generation #54

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

luepges
Copy link
Contributor

@luepges luepges commented Nov 12, 2024

  • FIX implicit scope-spanning symbols not having their spanned scope added as subscopes to their enclosing scope (and thus remove the need for OOSymbols#Method spanning a scope)
  • Add DeSer generation for SymTypeExpression attributes

@luepges luepges force-pushed the symtypexpression-deser branch from 06a5f88 to ab6dbbf Compare November 12, 2024 16:18
@SE-FDr
Copy link
Contributor

SE-FDr commented Nov 13, 2024

https://github.com/MontiCore/monticore/pull/55/commits
Apparently, this is not how to add request changes -> thus as PR for the PR

@luepges luepges marked this pull request as draft November 20, 2024 10:14
@luepges luepges force-pushed the symtypexpression-deser branch from 8fc8b03 to 2177d77 Compare November 21, 2024 17:25
@luepges luepges marked this pull request as ready for review November 21, 2024 17:57
@luepges luepges merged commit b098ef1 into dev Nov 22, 2024
18 checks passed
@luepges luepges deleted the symtypexpression-deser branch November 22, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants