Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix animated textures updater #483

Merged
merged 2 commits into from
Sep 23, 2023

Conversation

TheDuckCow
Copy link
Member

Fixed the reference which was causing a failure, and improve the tests to more directly check for an animated sequence node output.

All tests passing:

-------------------------------------------------------------------------------
bversion   	ran_tests	ran	skips	failed	errors
-------------------------------------------------------------------------------
(3.6.2)   	all_tests	35	2	0	No errors
(4.0.0)   	all_tests	35	2	0	No errors
(3.5.1)   	all_tests	35	2	0	No errors
(3.4.0)   	all_tests	35	2	0	No errors
(3.3.1)   	all_tests	35	2	0	No errors
(3.2.1)   	all_tests	35	2	0	No errors
(3.1.0)   	all_tests	35	2	0	No errors
(3.0.0)   	all_tests	35	2	0	No errors
(2.93.0)   	all_tests	35	2	0	No errors
(2.90.1)   	all_tests	35	2	0	No errors
(2.80.75)   	all_tests	34	3	0	No errors
tests took 204s to run

Turns out my own documentation in the original updater code was not
actually valid code, since the actual object passed in is a dictionary.
Copy link
Collaborator

@StandingPadAnimations StandingPadAnimations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I'm concerned about the amount of enums that had to be fixed for arguments though, I'm not sure how those made it past.

@StandingPadAnimations StandingPadAnimations merged commit 4c5405d into dev Sep 23, 2023
@StandingPadAnimations StandingPadAnimations deleted the fix-animated-textures-updater branch September 23, 2023 17:35
@StandingPadAnimations StandingPadAnimations restored the fix-animated-textures-updater branch September 23, 2023 17:35
@TheDuckCow TheDuckCow deleted the fix-animated-textures-updater branch September 27, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants