-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Added section on signing off commits #567
Conversation
Signed-off-by: Mahid Sheikh <mahid@standingpad.org>
Signed-off-by: Mahid Sheikh <mahid@standingpad.org>
Signed-off-by: Mahid Sheikh <mahid@standingpad.org>
Signed-off-by: Mahid Sheikh <mahid@standingpad.org>
Getting to this now, for my understanding: is the difference here just a matter of adding additional text into one's commit? Or is this tied to some certificate setup (in which case, should we be linking to how to set that up)? |
Got it, I think if we could include a link to some docs showing how to use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, presuming we'll add the context link showing how to use the signoff git flag
Signed-off-by: Mahid Sheikh <mahid@standingpad.org>
Done, I'll merge this in now |
This adds a section on signing off commits (noted to be optional, but useful), which is mostly a copy-paste of BpyBuild's section
To summarize: signing off commits is a way for the commit author to say, “Not only am I submitting this commit, the change made in this commit is allowed to be used”. This verifies:
As this is optional (although encouraged), this won't impact existing contributions to MCprep.