Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error message when prepping only mats with missing image paths. #611

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

TheDuckCow
Copy link
Member

Also resolves some pep8 warnings.

Local tests pass, but let's see about the github action runner. Tested off of a version of dev initially where the find missing function wasn't yet working, to prove the new message displays then. Also cleans up error code responses (though hm maybe we should just use the MCprep error class? though it's helpful to have the specific errno codes to check against right after).

Copy link
Collaborator

@StandingPadAnimations StandingPadAnimations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only issue with it is the use of integer error codes instead of the deticated error object, but that's something we can tackle at a later date

@TheDuckCow
Copy link
Member Author

Yup that's fair, I can take a quick stab at it as I'm wrapping up. This is the last change before go-live anyhow.

@TheDuckCow TheDuckCow linked an issue Aug 5, 2024 that may be closed by this pull request
3 tasks
@TheDuckCow
Copy link
Member Author

It was not, in fact, as simple as I had hoped - in that it really needed updating and trickle through handling of several functions, and felt weird to just do it halfway. So I created #612 to capture what I did so far and as a place for (anyone) completing the work. Merging this PR in the meantime.

@TheDuckCow TheDuckCow merged commit a5d816d into dev Aug 5, 2024
1 check passed
@TheDuckCow TheDuckCow deleted the 601-improved-error-handle-missing-paths branch August 5, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outstanding UAT fixes for 3.6.0
2 participants