Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed FluentAssertions in favour of Shouldly #17

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Conversation

MooVC
Copy link
Owner

@MooVC MooVC commented Jan 18, 2025

Pull Request

Description

Please provide a brief description of the changes you have made, including the problem this PR solves, or the feature it implements.

Migration from FluentAssertions to Shouldly. There is no functional change to Valuify in this push.

Checklist

Please ensure the following are true for your PR:

  • I have followed the project's coding style guidelines.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have verified that new and existing unit tests pass locally with my changes.
  • I have updated the documentation (if applicable).
  • I have confirmed that my code is free from warnings and errors.
  • I have reviewed suggestions and determined no actions is required.
  • I have updated the CHANGELOG.md
  • I have performed a self-review of my code.

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.95%. Comparing base (987de3c) to head (96baaaf).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   92.95%   92.95%           
=======================================
  Files          37       37           
  Lines         696      696           
  Branches       69       69           
=======================================
  Hits          647      647           
  Misses         22       22           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MooVC MooVC merged commit 098093b into master Jan 18, 2025
7 checks passed
@MooVC MooVC deleted the feature/pm-shouldly branch January 18, 2025 23:01
@jcfnomada
Copy link

Please the possibility to use https://github.com/AwesomeAssertions/AwesomeAssertions. There are a lot of old a recent contributers already in the project, so it is expected to continue it's work with bug fixes and new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants