Game of Life Memory Leak Fix + Other Changes #133

Brandon502 · 2024-05-24T18:19:53Z

Fixed memory leak using new. Removed gameoflife struct and reverted back to using pointers to segenv.data (similar to starLeds version).

Added Blur slider. Blurs dead cells slowly to bgColor depending on slider instead of immediately dying. Doesn't effect game logic.

Removed confusing pauseFrames, uses .step to pause now.

Keeps track of last palette used and immediately recolors cells if new palette/color selected. Can be improved.

Changes gameSpeed slider to be more consistent. Speed = updates/second now in increments of 4.

Removed gameoflife struct.

Blurs dead cells instead of immediately turning off depending on slider value. Blur is disabled when using overlay.

Uses .step now to pause.

General cleanup.

Recolors all live cells on palette/color change. Before you needed a game restart or mutation over time.

Every 4 ticks of speed adds 1 update per second. 1 - 64.

Brandon502 · 2024-05-24T18:23:17Z

Please look over palette change code and game speed.
I couldn't figure out a way to store the actual previous palette used, so it cheats by just using the first color of the palette. This works most of the time. Only doesn't switch immediately if two palettes share same 0 index color (rainbow/rainbow stripe).
Game update speed is capped to 64 updates/second which may be too fast depending on setup. Not sure if this can cause issues so may need adjusting.

softhack007 · 2024-06-03T11:02:59Z

Hi, thanks for this update.
I'll look into the details like game speed in the next days, and then we can merge it into the code for the new release of WledMM (it's still the same "upcoming" release)

I couldn't figure out a way to store the actual previous palette used, so it cheats by just using the first color of the palette

You could use uint8_t currentPal = SEGMENT.palette; to get the current palette ID.
Downside: sometimes a palette is dynamically adjusted, while the ID stays the same. For example: during effect blending, or when using one of the audioreactive palettes. So this would also not make the code 100% bullet proof.

But your "cheat" is OK for me, too. It doesn't need to be a perfect solution.

Brandon502 · 2024-06-04T01:05:35Z

uint8_t currentPal = SEGMENT.palette;

Some how overlooked this. Didn't think about palettes that change overtime, keeping the first color would work better for those. Each method seems to have a slight drawback, implementing both would be overkill. I'll have to test out those special palettes.

I have a few more changes I've made in StarLeds that I need to convert to WLED and push. Finally figured out a way to make blending look better when a game starts repeating.

Blur now fades while game is paused. New blur mode when blur slider is >220 Added variables to make code easier to follow instead of check1 custom1 etc. (not needed) Removed % with random8 calls. Misc changes

Brandon502 · 2024-06-04T20:29:10Z

I'll post videos when I get a chance later. Code is a bit more complicated, especially the new redraw loop. Added new blend option when blur slider >220. There is an unintended effect when you have two segments and overlay off. Looks really good on high game speeds, but breaks (flashes) on lower ones. Tried a few ways to get it working on lower speeds but no luck.

Default parameters don't seem to be working. May just be using progmem incorrectly. Edit: It works, just had WLED setting enabled that ignores default.

futureCells is technically not needed to be stored in memory. It is only needed when game updates occur.

@softhack007 I ended going with your suggestion with storing palette index. It looks nicer with palettes that cycle. Only downside is if using single/gradient color wheel options they don't instantly switch. Still works overtime though, so not a huge deal.

Brandon502 · 2024-06-05T01:44:12Z

Short video showing the new options.

Top left: Blur >220. The background keeps a faded color of the last alive cell on that led. Kind of a history/turf war of the alive colors.
Top right: High blur value with multiple palette changes to show instant switching and blur fading as the game ends.
Bottom left: Unintended effect when you turn off overlay when you have another effect in the background. Alive cells take the background color and you can apply a different blur color. Video shows white then switching to Atlantica.
Bottom right: Side effect when game speed is too low, tons of flashing since there are effects stacked. May be able to figure out how to prevent it so there would be a second overlay type without a toggle.

Edit: Fixed flicker issue. Can now swap between overlay types.

GoLBlurOverlay.mp4

Flicker fixed by always redrawing dead cells if overlay unchecked. Can swap between overlay types by checking/unchecking overlayBG.

Fixed overlooked data allocation after switching gliderLength to uint16.

Brandon502 · 2024-06-05T16:43:02Z

Stress tested on a 64x32 matrix with 4 pins. Showing 30 FPS with max game speed. 40+ when updating is set to 20/sec.

32x64GoL.mp4

32x64GoLOverlay.mp4

Rainbow Background Overlay a bit higher FPS around 33. Opposite "overlay" 24 FPS.

Wrap is disabled if only 5 remaining alive cells (Glider).

softhack007

Hi, thanks for the update.
i've tested your new code quickly, and it works for me.

Below some recommendations that could slightly improve speed.

wled00/FX.cpp

softhack007 · 2024-06-19T17:26:10Z

wled00/FX.cpp

-      if (!SEGMENT.check2) SEGMENT.setPixelColorXY(x,y, !SEGMENT.check1?backgroundColor : RGBW32(backgroundColor.r, backgroundColor.g, backgroundColor.b, 0));
+      setBitValue(futureCells, cIndex, false);
+      // Blur/turn off dying cells
+      if (!overlayBG) SEGMENT.setPixelColorXY(x,y, blend(SEGMENT.getPixelColorXY(x,y), bgColor, bgBlendMode ? bgBlur : blur));


optimization: try to use color_blend() instead of blend()

wled00/FX.cpp

Brandon502 · 2024-06-19T19:19:48Z

Is this a known issue regarding overlays "breaking"?

Normal overlay:

SoapNormal.mp4

Glitched overlay:

SoapGlitched.mp4

Seems like the segments start sharing colors instead of keeping them separate. It allows for some neat effects. Just makes debugging annoying when I don't want it to happen.

GoLGlitchedOverlay.mp4

Other small changes.

wled00/FX.cpp

softhack007 · 2024-06-19T19:56:58Z

Is this a known issue regarding overlays "breaking"?

Normally not - only two exceptions that I know about

"Use global LED buffer" enabled - this makes all pixels shared (plus known bug ghost pixels with "Use global LED buffer" #58)
effects run with 1D->2D mapping (pinwheel, bar, etc.) In this case the segment buffer cannot be used by getPixelColor(), so all pixels are read back from the "shared" hardware driver

Remove redundant check

Brandon502 · 2024-06-19T23:09:03Z

@softhack007 I think I made all your recommended changes. Although I am not sure when to use uint32_t wled_color = uint32_t(fastled_color) & 0x00FFFFFF conversion. Currently just set all CRGB to uint32. Everything seems to work, using color_blend didn't have a noticeable affect on FPS on my end, ~+1 FPS.

There is one last thing I'd like to add to ease transition between games. It doesn't seem to want to cooperate with all options yet though.

Starting alive cells are randomly colored in and bg fades on game start.

Merged generation == 1 checks into standard checks.

Brandon502 · 2024-06-20T05:15:09Z

Finally got alive cells to spawn in randomly on game start working on everything, but overlayBG. Had a small flicker on start so decided to remove it. Looks a lot better with transition between games. The redraw loop is even more complicated now unfortunately.

softhack007

Thanks, looks good 👍

Just tell once you're happy with the code, and i'll merge it into mdev.

Brandon502 · 2024-06-20T16:04:49Z

Thanks, looks good 👍

Just tell once you're happy with the code, and i'll merge it into mdev.

Sounds good, I'll play around with it some more for a day or two to make sure everything is working normally and no bugs pop up. I'll let you know soon.

Brandon502 · 2024-06-22T21:40:51Z

@softhack007 Haven't run into any bugs on my setup so far. Feel free to merge whenever.

Brandon502 added 8 commits May 24, 2024 11:35

GoL Memory Leak fix

eb3406e

Removed gameoflife struct.

GoL - Added blur slider

09dad1d

Blurs dead cells instead of immediately turning off depending on slider value. Blur is disabled when using overlay.

GoL - Removed pauseFrames

8491cf1

Uses .step now to pause.

GoL - Change default values.

631aa35

General cleanup.

GoL - Palette Switching

886ea5f

Recolors all live cells on palette/color change. Before you needed a game restart or mutation over time.

GoL - Changed speed slider to updates/sec

84128ee

Every 4 ticks of speed adds 1 update per second. 1 - 64.

Merge branch 'MoonModules:mdev' into mdev

b673748

Merge branch 'mdev' of https://github.com/Brandon502/WLED into mdev

aea68df

Brandon502 added 2 commits May 24, 2024 14:38

GoL - Uses cIndex more consistently

7657c90

Merge remote-tracking branch 'upstream/mdev' into mdev

56ae0b0

Brandon502 added 3 commits June 4, 2024 12:06

Merge branch 'MoonModules:mdev' into mdev

5baffaf

GoL - Rework

8c3e2ce

Blur now fades while game is paused. New blur mode when blur slider is >220 Added variables to make code easier to follow instead of check1 custom1 etc. (not needed) Removed % with random8 calls. Misc changes

Merge branch 'mdev' of https://github.com/Brandon502/WLED into mdev

9f1ea87

Brandon502 added 3 commits June 5, 2024 01:07

GoL - Allows default overlay mode.

f528aef

Flicker fixed by always redrawing dead cells if overlay unchecked. Can swap between overlay types by checking/unchecking overlayBG.

GoL - gliderLength switched to uint16_t

c655db3

GoL - Correct data allocation

5a6d80f

Fixed overlooked data allocation after switching gliderLength to uint16.

Brandon502 added 2 commits June 9, 2024 15:50

GoL - Small color fix and glider detection change.

015260c

Wrap is disabled if only 5 remaining alive cells (Glider).

Merge remote-tracking branch 'upstream/mdev' into mdev

3d12f0f

softhack007 requested changes Jun 19, 2024

View reviewed changes

GoL CRGB changed to uint32 & color_blend()

e8e784d

Other small changes.

softhack007 reviewed Jun 19, 2024

View reviewed changes

wled00/FX.cpp Outdated Show resolved Hide resolved

softhack007 reviewed Jun 19, 2024

View reviewed changes

wled00/FX.cpp Outdated Show resolved Hide resolved

GoL - Small fix

4aee7eb

Remove redundant check

Brandon502 added 2 commits June 19, 2024 23:09

GoL - Game start transition

086b0e3

Starting alive cells are randomly colored in and bg fades on game start.

GoL - Redraw loop changes

9ef8ff6

Merged generation == 1 checks into standard checks.

softhack007 approved these changes Jun 20, 2024

View reviewed changes

softhack007 merged commit 6dd8f6e into MoonModules:mdev Jun 22, 2024
34 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Game of Life Memory Leak Fix + Other Changes #133

Game of Life Memory Leak Fix + Other Changes #133

Brandon502 commented May 24, 2024

Brandon502 commented May 24, 2024

softhack007 commented Jun 3, 2024 •

edited

Loading

Brandon502 commented Jun 4, 2024

Brandon502 commented Jun 4, 2024 •

edited

Loading

Brandon502 commented Jun 5, 2024 •

edited

Loading

Brandon502 commented Jun 5, 2024 •

edited

Loading

softhack007 left a comment •

edited

Loading

softhack007 Jun 19, 2024

Brandon502 commented Jun 19, 2024

softhack007 commented Jun 19, 2024 •

edited

Loading

Brandon502 commented Jun 19, 2024 •

edited

Loading

Brandon502 commented Jun 20, 2024

softhack007 left a comment

Brandon502 commented Jun 20, 2024

Brandon502 commented Jun 22, 2024

Game of Life Memory Leak Fix + Other Changes #133

Game of Life Memory Leak Fix + Other Changes #133

Conversation

Brandon502 commented May 24, 2024

Brandon502 commented May 24, 2024

softhack007 commented Jun 3, 2024 • edited Loading

Brandon502 commented Jun 4, 2024

Brandon502 commented Jun 4, 2024 • edited Loading

Brandon502 commented Jun 5, 2024 • edited Loading

Brandon502 commented Jun 5, 2024 • edited Loading

softhack007 left a comment • edited Loading

Choose a reason for hiding this comment

softhack007 Jun 19, 2024

Choose a reason for hiding this comment

Brandon502 commented Jun 19, 2024

softhack007 commented Jun 19, 2024 • edited Loading

Brandon502 commented Jun 19, 2024 • edited Loading

Brandon502 commented Jun 20, 2024

softhack007 left a comment

Choose a reason for hiding this comment

Brandon502 commented Jun 20, 2024

Brandon502 commented Jun 22, 2024

softhack007 commented Jun 3, 2024 •

edited

Loading

Brandon502 commented Jun 4, 2024 •

edited

Loading

Brandon502 commented Jun 5, 2024 •

edited

Loading

Brandon502 commented Jun 5, 2024 •

edited

Loading

softhack007 left a comment •

edited

Loading

softhack007 commented Jun 19, 2024 •

edited

Loading

Brandon502 commented Jun 19, 2024 •

edited

Loading