ES8388 LyraT Fixes #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netmindz
reviewed
May 4, 2023
|
|
||
| // #define use_es8388_mic | ||
|
|
||
| #ifdef use_es8388_mic |
There was a problem hiding this comment.
The convention is normally to use block caps for build flags
netmindz
requested changes
May 4, 2023
| @@ -551,6 +598,10 @@ class ES8388Source : public I2SSource { | |||
|
|
|||
| void initialize(int8_t sdaPin, int8_t sclPin, int8_t i2swsPin, int8_t i2ssdPin, int8_t i2sckPin, int8_t mclkPin) { | |||
|
|
|||
| // BUG: "use global I2C pins" are valid as -1, and -1 is seen as invalid here. | |||
| // Workaround: Set I2C pins here, which will also set them globally. | |||
| // Bug also exists in ES7243. | |||
There was a problem hiding this comment.
Worth logging a bug so we keep track to come back and fix both?
|
Just tested and pass-thru working (at least to some extent, not verified left/right balance etc) Just the naming that build flag and I'd say good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional mic at compile time (set in code)
Fixes to a small volume drop on pass-thru on the LyraT on one stereo channel. Unknown as to why this happens in the hardware.
Moved all registry numbers to decimal and all settings to binary format to make it easier to cross-reference the manuals which all shows decimal and binary. Tried to document all settings in-line as best as I can.
Added some more docs to the comments as hints for those who might want to do further hacking. :)