Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES8311 Support #168

Merged
merged 1 commit into from
Dec 3, 2024
Merged

ES8311 Support #168

merged 1 commit into from
Dec 3, 2024

Conversation

troyhacks
Copy link
Collaborator

@troyhacks troyhacks commented Oct 2, 2024

This one was a bit more messy to add, as there's a lot of bits to be set for proper MCLK division that I can't claim to fully understand, but reverse-engineered from the Espressif driver and some other hints I found.

Initializes properly for the ES8311 chip found on the ESP32-P4 EV board with integrated mic, but should likely work for other implementations as it's a very simple codec chip that that only has mic input.

It frustratingly works,,, most of the time. Sometimes it absolutely comes up in the wrong state. Looking into it still, but it is generally functional.

I think it's something to do with Auto Gain Control in the codec chip for the mic. Might be fighting with the same sort of logic in WLED.

@troyhacks troyhacks marked this pull request as draft October 2, 2024 15:54
@netmindz
Copy link
Collaborator

Worth merging even if it's a little temperamental?

@troyhacks
Copy link
Collaborator Author

Worth merging even if it's a little temperamental?

I guess? The code works just fine, it's the I2C commands that seem to need a tweak. It would be good to have it in mdev so it's there when people come across it - and then can report bugs.

Also the entire installed user base for the ES8311 is likely just me at the moment. 🤣

@netmindz netmindz marked this pull request as ready for review December 3, 2024 14:48
@netmindz netmindz merged commit 67e7829 into MoonModules:mdev Dec 3, 2024
36 checks passed
@troyhacks troyhacks deleted the ES8311-Support branch December 4, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants