Update polkadot-sdk to stable2407 #52
Conversation
| @@ -466,7 +466,7 @@ fn transfer_from_self() { | |||
| value: 400.into(), | |||
| }, | |||
| ) | |||
| .expect_cost(176215756) // 1 weight => 1 gas in mock | |||
| .expect_cost(173364756) // 1 weight => 1 gas in mock | |||
There was a problem hiding this comment.
I had to change this value because these tests failed, I don't know if this will break anything
| @@ -557,8 +368,24 @@ version = "0.5.2" | |||
| source = "registry+https://github.com/rust-lang/crates.io-index" | |||
| checksum = "7f6fd5ddaf0351dff5b8da21b2fb4ff8e08ddd02857f0bf69c47639106c0fff0" | |||
| dependencies = [ | |||
| "asn1-rs-derive", | |||
| "asn1-rs-impl", | |||
| "asn1-rs-derive 0.4.0", | |||
There was a problem hiding this comment.
Where theses duplicates come from?
Can you try to avoid them by using the same versions of the dependencies that use them?
There was a problem hiding this comment.
Essentially it comes from libp2p and litep2p using different versions of x509-parser. Unfortunately I don't think we can fix it, as those are defined in polkadot-sdk.
And polkadot-sdk has the same issue in their Cargo.lock: https://github.com/paritytech/polkadot-sdk/blob/035211d707d0a74a2a768fd658160721f09d5b44/Cargo.lock#L8121
There was a problem hiding this comment.
Ho I see, is there already a GH issue on polkadot-sdk about that?
|
The build fails because of this: I decided to ignore it for now, I will add allow(deprecated) if that's ok |
No description provided.