Fix to patching decimals in JsonMergePatch.SystemText #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are changes specific to the SystemText.JSON implementation of this framework
Developed to fix issue #38
I have added a JSONElement extension
GetGenericNumber
to the SystemText Patch BuilderPreviously it would cast all JSON numbers to an Int64 (even if they were decimal)
Now, it will attempt to cast to an Int64 and failing that, will cast to a decimal instead
This should allow for patching of both integer and floating point numbers
I have also added a new test to demonstrate this working for both scenarios
@Morcatko - could you run your eyes over this and make sure I've not missed anything obvious ? Cheers