feat: add unit test support to system text json version #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Morcatko
reviewed
Aug 15, 2024
src/6.0-JsonMergePatch.SystemText/6.0-JsonMergePatch.SystemText.csproj
Outdated
Show resolved
Hide resolved
…use System.Text.Json. Add unit test that covers complete patch case from start to finish with patching, ignoring and null value replacement
|
Hi @Morcatko Could you please review the PR and approve if everything is okay? We are going live soon and would love to have all our PATCH endpoints covered by unit tests. :) |
omorsky-pcor
approved these changes
Aug 19, 2024
Morcatko
approved these changes
Aug 19, 2024
Morcatko
requested review from
omorsky-pcor
and removed request for
omorsky-pcor
|
Released in version 6.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the ability to do unit tests on the 6.0 version for System.Text.Json, like you could do in the newtonsoft version.
This is my first ever public PR that I barely managed to scrape together, but it works and I wrote a few small unit tests for it.
If there are any bigger structural problems that need fixing I would appreciate some guidance. If not, great! :)