Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use non parsed version string to check if version is used #182

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

guilhas07
Copy link
Contributor

Use the non_parsed_string instead of tag_name to allow users to remove nightly rollbacks while on the most recent nightly version.

@guilhas07
Copy link
Contributor Author

I don't know if this was a regression on the tag_name behaviour because here #180 (comment) the nightly version string seemed to be correct.

@MordechaiHadad
Copy link
Owner

I don't know if this was a regression on the tag_name behaviour because here #180 (comment) the nightly version string seemed to be correct.

I dunno lol, will this PR only apply to selection uninstall or uninstall as a whole?

@guilhas07
Copy link
Contributor Author

I dunno lol, will this PR only apply to selection uninstall or uninstall as a whole?

Yes, only for the selection uninstall.

@MordechaiHadad
Copy link
Owner

I dunno lol, will this PR only apply to selection uninstall or uninstall as a whole?

Yes, only for the selection uninstall.

why not the entire command? could be cool since u already doing so

@guilhas07
Copy link
Contributor Author

guilhas07 commented Jan 29, 2024

why not the entire command? could be cool since u already doing so

Yeah, I totally forgot this was a problem too on the normal uninstall 😅.

@MordechaiHadad
Copy link
Owner

works great!

@MordechaiHadad MordechaiHadad merged commit e521723 into MordechaiHadad:master Jan 30, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants