-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement flag to download AUR packages via SSH #669
Conversation
Oh, the workaround mentioned in #399 is problematic when updating the system since all those clones are done with SSH and require authorising the agent. |
Are you saying it will fail to pull over ssh on an aur repo you don't own? |
No, that's not it. The issue with the override in #399 is that all AUR clones are done via SSH, so if I run something like I also intend on using a hardware-backed (e.g.: yubikey) SSH keys for the AUR as soon as support for that is deployed, but that won't help much; I'll still need to tap the key for each clone. In reality, I don't want to clone via SSH most of the time, only in exceptional situations when I want to make changes and push them back. |
Right that sounds reasonable, though i'd rather the name be --ssh. Also you hard coded the url. you should instead take url that is configured. |
👍
Do you mean a new config setting with the base SSH url? |
No new section. just take the normal aururl and change the protocol to ssh. |
I think all comments have been resolved and CI is green. Thanks for all your patience on this one. |
.to_string() | ||
.replacen("https://", "ssh://aur@", 1) | ||
.parse() | ||
.expect("change AUR URL schema from HTTPS to SSH") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use ? instead
Implement a new `-s` or `--ssh` flag to download AUR packages using SSH. Fixes #399
Also updated commit message and man page. |
Thanks! |
@WhyNotHugo wrote:
I mean you can use SSH connection multiplexing for the AUR, this should reuse the authentication :) |
Implement a new
-e
or--editable
flag to download AUR packages usingSSH.
Fixes #399