Fix: sends right index on first operation

[grunch]

Fix #109

Summary by CodeRabbit

Release Notes

• Bug Fixes

  • Corrected trade index tracking mechanism across multiple user operations
  • Ensured consistent last trade index recording without unnecessary incrementation

• Refactor

  • Simplified trade index management in user-related functions
  • Standardized trade index assignment logic across different command handlers

• Chores

  • Updated internal trade key generation process
  • Minor optimization of user data management

[coderabbitai]

Walkthrough

The pull request introduces modifications to several files in the CLI and database modules, focusing on the trade index handling mechanism. The primary change involves adjusting how the last trade index is set and retrieved across multiple functions. The modifications aim to address an issue with trade key generation, specifically how the initial trade index is handled when creating or taking orders.

Changes

File	Change Summary
src/cli.rs	Added mostro_key initialization using PublicKey::from_str()
src/cli/get_dm.rs	Modified trade index update to use current index instead of incrementing
src/cli/new_order.rs	Changed last trade index update to use current trade index
src/cli/send_msg.rs	Updated trade index setting to use current index
src/cli/take_buy.rs	Adjusted last trade index setting to current trade index
src/cli/take_sell.rs	Modified trade index update to use current index
src/db.rs	Removed trade index decrementing logic in get_next_trade_keys method

Assessment against linked issues

Objective	Addressed	Explanation
Fix trade key generation for first operation	✅
Ensure correct initial trade index	✅

Poem

🐰 A rabbit's tale of trade and key,
Where indexes dance with glee,
No more zero, no more strife,
Mostro's CLI finds new life!
Hop along, trade keys so bright! 🔑

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/cli.rs (1)

310-310: Improve error handling for invalid Mostro pubkey
If an invalid pubkey is provided, it might be beneficial to include the offending pubkey in the error message so the user can quickly identify the issue.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 49be68b and 617aa5c.

📒 Files selected for processing (7)

• src/cli.rs (1 hunks)
• src/cli/get_dm.rs (1 hunks)
• src/cli/new_order.rs (1 hunks)
• src/cli/send_msg.rs (1 hunks)
• src/cli/take_buy.rs (1 hunks)
• src/cli/take_sell.rs (1 hunks)
• src/db.rs (1 hunks)

🔇 Additional comments (6)

src/cli/take_buy.rs (1)

98-98: Confirm the correctness of no-increment logic.

Previously, the code incremented the trade index by 1. Now, it simply sets the last trade index to the current trade_index. Ensure that any logic in the codebase expecting this index to be bumped up (e.g., if referencing the "next" trade index) is properly updated.

Would you like me to generate a shell script to locate other references to the user’s last trade index usage and check for potential off-by-one errors?

src/cli/take_sell.rs (1)

120-120: Maintain consistency in trade index usage.

This change removes the increment step from the last trade index updating logic. Verify that this aligns with the rest of the system, particularly if there are any calculations downstream that rely on the index being incremented after each trade.

src/cli/send_msg.rs (1)

105-105: Ensure the updated index logic matches order creation flow.

The index is directly assigned to trade_index instead of incrementing it. Confirm that no other workflow stage (e.g., new order creation or invoice generation) expects an incremented trade index.

src/cli/get_dm.rs (1)

88-88: Validate index continuity across new orders.

When creating a new DB order, the code sets the last trade index to the current trade_index. Check if the rest of the order management logic, especially in the “new order” scenario, is consistent with not incrementing the index.

src/cli/new_order.rs (1)

185-185: Ensure concurrency safety for last_trade_index updates
If multiple orders are created in parallel, there's a risk that the same trade index could be assigned to separate orders. Consider using transactions or other concurrency-control mechanisms (e.g., row-level locks or optimistic concurrency checks) to avoid conflicts.

src/db.rs (1)

173-173: Consistent trade index usage
This direct assignment to trade_index aligns with your updated approach of not decrementing the value. Glad to see the consistency with other modules.