Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker setup and guide for building and running MostroP2P #307

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

tincho70
Copy link
Contributor

Summary

This PR adds Docker support to the MostroP2P repository, including a new Docker guide (DOCKER.md) and all necessary files to build and run the application using Docker and Docker Compose.

Changes

  • Added DOCKER.md file with detailed instructions for:
    • Prerequisites for Docker and Docker Compose
    • Building and running the Docker container
    • Docker Compose configuration
  • Added Dockerfile to define the Docker image build process.
  • Added compose.yml for Docker Compose configuration.
  • Added empty.mostro.db, an empty SQLite database required by the application.
  • Added settings.docker.toml, a configuration file (template) for the application.
  • Added start.sh, a script to start the application inside the Docker container.

Why

These additions will help users and developers set up and run the MostroP2P application using Docker and Docker Compose, ensuring a consistent and simplified setup process. This will also make it easier to manage dependencies and environment configuration.

@grunch @arkanoider Please review the changes and provide feedback.

@grunch grunch assigned grunch and unassigned grunch Jun 24, 2024
@grunch grunch requested review from grunch and arkanoider June 24, 2024 13:34
@arkanoider
Copy link
Collaborator

If it works @grunch i think it's a super cool add, ease the process to play with mostrod.
For me it's a merge!

Copy link
Member

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great add @tincho70 LGTM!

Copy link
Collaborator

@arkanoider arkanoider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge it!

@grunch
Copy link
Member

grunch commented Jun 24, 2024

Merge it!

approve it

@grunch grunch requested a review from arkanoider June 24, 2024 20:41
@grunch grunch merged commit f037662 into MostroP2P:main Jun 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants