Implement gift wrap

[grunch]

Fix #214

Summary by CodeRabbit

Release Notes

• New Features

  • Introduced a new module for managing "gift wrap" events, enhancing event handling capabilities.
  • Added functionality for creating and unwrapping gift wrap events.

• Improvements

  • Streamlined event processing by updating the event structure to utilize UnwrappedGift, ensuring consistent access to sender information across various actions.
  • Enhanced message handling and error logging for better user experience.
  • Increased maximum size for event messages, allowing for more extensive content.

• Bug Fixes

  • Corrected references to public keys in multiple functions to ensure accurate messaging and event handling.

• Documentation

  • Updated function signatures to reflect changes in event parameter types and added new functionalities.

[arkanoider]

Relly clean and nice! LGTM!
We did quite well centralizing message sent, no greati modifications!

[arkanoider]

Relly clean and nice! LGTM!
We did quite well centralizing message sent, no great modifications needed!

[grunch]

@coderabbitai review

[coderabbitai]

@grunch: I will review the changes.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces significant changes across multiple files, primarily focusing on the transition from using the Event type to the UnwrappedGift type for event handling. This change affects how various functions access event properties, specifically replacing instances of pubkey with sender. Additionally, a new module nip59 is introduced, which includes functions for creating and managing gift wrap events. The changes aim to streamline event processing and enhance message handling within the application.

Changes

File	Change Summary
src/app.rs	Updated run function to handle Kind::GiftWrap events using unwrap_gift_wrap.
src/app/add_invoice.rs	Changed event parameter type from &Event to &UnwrappedGift, updated references from event.pubkey to event.sender.
src/app/admin_add_solver.rs	Changed event parameter type from &Event to &UnwrappedGift, updated references from event.pubkey to event.sender.
src/app/admin_cancel.rs	Changed event parameter type from &Event to &UnwrappedGift, updated references from event.pubkey to event.sender.
src/app/admin_settle.rs	Changed event parameter type from &Event to &UnwrappedGift, updated references from event.pubkey to event.sender.
src/app/admin_take_dispute.rs	Changed event parameter type from &Event to &UnwrappedGift, updated references from event.pubkey to event.sender.
src/app/cancel.rs	Changed event parameter type from &Event to &UnwrappedGift in multiple functions, updated references from event.pubkey to event.sender.
src/app/dispute.rs	Changed event parameter type from &Event to &UnwrappedGift, updated references from event.pubkey to event.sender.
src/app/fiat_sent.rs	Changed event parameter type from &Event to &UnwrappedGift, updated references from event.pubkey to event.sender.
src/app/order.rs	Changed event parameter type from &Event to &UnwrappedGift, updated references from event.pubkey to event.sender.
src/app/rate_user.rs	Changed event parameter type from &Event to &UnwrappedGift, updated references from event.pubkey to event.sender.
src/app/release.rs	Changed event parameter type from &Event to &UnwrappedGift, updated references from event.pubkey to event.sender.
src/app/take_buy.rs	Changed event parameter type from &Event to &UnwrappedGift, updated references from event.pubkey to event.sender.
src/app/take_sell.rs	Changed event parameter type from &Event to &UnwrappedGift, updated references from event.pubkey to event.sender.
src/main.rs	Added new module nip59, modified subscription timestamp logic.
src/nip59.rs	Introduced functions for managing gift wrap events: gift_wrap, seal, gift_wrap_from_seal, and unwrap_gift_wrap.
src/util.rs	Updated send_dm to use gift_wrap, changed settle_seller_hold_invoice parameter type from &Event to &UnwrappedGift.

Assessment against linked issues

Objective	Addressed	Explanation
Replace nip 04 with nip 44 for communication (#214)	✅

Possibly related PRs

• Rabbit insipired unwrap removal #382: The changes in add_invoice_action regarding the handling of event parameters and the transition from pubkey to sender are related to the modifications in the main PR, which also involves similar updates to event handling and the introduction of the unwrap_gift_wrap function.

Poem

🐇 In the meadow where gifts do wrap,
A new way to send, no need for a map.
With sender in hand, we dance and we play,
Unwrapping the joy in a bright, sunny way!
So hop along, friends, let’s share and delight,
For every new change makes our coding take flight! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.