Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix on cooperative cancellations #361

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Bug fix on cooperative cancellations #361

merged 1 commit into from
Sep 19, 2024

Conversation

grunch
Copy link
Member

@grunch grunch commented Sep 19, 2024

Fix #360

Catrya
Catrya approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@Catrya Catrya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funciona bien! aunque creo al usuario que envía el cancel mostro le debería enviar CantDo para que sepa que no puede

@grunch
Copy link
Member Author

grunch commented Sep 19, 2024

funciona bien! aunque creo al usuario que envía el cancel mostro le debería enviar CantDo para que sepa que no puede

Un usuario que intenta cancelar desde una private key que no tiene nada que ver con la orden ya sabe por qué no puede, no vamos a gastar recursos para enviar mensajes a un atacante

@grunch grunch merged commit 9847e13 into main Sep 19, 2024
1 check passed
@grunch grunch deleted the issue-360_cooperative-cancellations-bug branch September 20, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Catrya Catrya Catrya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug with cooperative cancellations
2 participants
@grunch @Catrya