Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for vote user #60

Merged
merged 7 commits into from
Apr 28, 2023
Merged

Fix for vote user #60

merged 7 commits into from
Apr 28, 2023

Conversation

arkanoider
Copy link
Collaborator

Hi @grunch ,

set content of dm from mostro to signal user to vote to None

@grunch
Copy link
Member

grunch commented Apr 27, 2023

this PR is still in progress?

@arkanoider
Copy link
Collaborator Author

I wanted to fix at least the other point, but i think that for tonite i am finished....:)

@grunch
Copy link
Member

grunch commented Apr 27, 2023

great, after you finish make sure you marked it as ready for review that way contributors know that we can review it, get rest 😃

…rating with 2 decimals.

Added a confirmation message after user vote received
Removed pubkey from Peer Content.
@grunch
Copy link
Member

grunch commented Apr 28, 2023

is this ready for review?

@arkanoider arkanoider marked this pull request as ready for review April 28, 2023 13:36
Copy link
Member

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grunch grunch merged commit c1d444e into MostroP2P:main Apr 28, 2023
@arkanoider arkanoider deleted the fix_for_vote_user branch April 28, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants