filter widget no longer crashes - fixes #213

Mottie · Jan 10, 2013 · d527cca · d527cca
1 parent 786f2f3
commit d527cca
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -36,6 +36,10 @@ tablesorter can successfully parse and sort many types of data including linked
 
 View the [complete listing here](https://github.com/Mottie/tablesorter/wiki/Change).
 
+#### Version 2.7.3 (1/10/2013)
+
+* Fixed a serious bug in the filter widget that was breaking the widget completely if `filter_functions` was not defined. Fixes [issue #213](https://github.com/Mottie/tablesorter/issues/213).
+
 #### Version 2.7.2 (1/8/2013)
 
 * Updated filter widget to update the filter-select when an update event is triggered. See [this StackOverflow question](http://stackoverflow.com/q/14223044/145346).

diff --git a/js/jquery.tablesorter.js b/js/jquery.tablesorter.js
@@ -1,5 +1,5 @@
 /*!
-* TableSorter 2.7.2 - Client-side table sorting with ease!
+* TableSorter 2.7.3 - Client-side table sorting with ease!
 * @requires jQuery v1.2.6+
 *
 * Copyright (c) 2007 Christian Bach
@@ -24,7 +24,7 @@
 
 			var ts = this;
 
-			ts.version = "2.7.2";
+			ts.version = "2.7.3";
 
 			ts.parsers = [];
 			ts.widgets = [];

diff --git a/js/jquery.tablesorter.min.js b/js/jquery.tablesorter.min.js
diff --git a/js/jquery.tablesorter.widgets.js b/js/jquery.tablesorter.widgets.js
@@ -1,4 +1,4 @@
-/*! tableSorter 2.4+ widgets - updated 1/8/2013
+/*! tableSorter 2.4+ widgets - updated 1/10/2013
  *
  * Column Styles
  * Column Filters
@@ -489,7 +489,7 @@ $.tablesorter.addWidget({
 				for (i = 0; i < cols; i++){
 					t = $ths.filter('[data-column="' + i + '"]:last');
 					// look for the filter-select class; build/update it if found
-					if ((t.hasClass('filter-select') || wo.filter_functions[i] === true) && !t.hasClass('filter-false')){
+					if ((t.hasClass('filter-select') || wo.filter_functions && wo.filter_functions[i] === true) && !t.hasClass('filter-false')){
 						if (!wo.filter_functions) { wo.filter_functions = {}; }
 						wo.filter_functions[i] = true; // make sure this select gets processed by filter_functions
 						buildSelect(i, updating);

diff --git a/js/jquery.tablesorter.widgets.min.js b/js/jquery.tablesorter.widgets.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "tablesorter",
-    "version": "2.7.2",
+    "version": "2.7.3",
     "title": "tablesorter",
     "author": {
         "name": "Christian Bach",